organicmaps/organicmaps
32
Fork 21
Code Issues 2.7k Pull requests 196 Projects Releases 65 Wiki Activity Actions

[android-auto] Refactoring #4989

Merged
root merged 1 commit from github/fork/AndrewShkrob/android-auto/refactoring into aa 2023-04-17 20:26:01 +00:00
Conversation 18 Commits 1 Files changed 15 +130 -97
AndrewShkrob commented 2023-04-15 15:26:54 +00:00
Member
Copy link

Links to #4936

Links to https://git.omaps.dev/organicmaps/organicmaps/pulls/4936
AndrewShkrob commented 2023-04-15 15:27:27 +00:00
Author
Member
Copy link

mentioned in merge request !4936

mentioned in merge request !4936
AndrewShkrob commented 2023-04-15 15:32:57 +00:00
Author
Member
Copy link

requested review from @rtsisyk

requested review from `@rtsisyk`
AndrewShkrob commented 2023-04-15 15:33:02 +00:00
Author
Member
Copy link

requested review from @biodranik

requested review from `@biodranik`
biodranik commented 2023-04-15 15:39:54 +00:00 (Migrated from github.com)
Copy link

Add TODO why is it commented, and when it should be uncommented?

Add TODO why is it commented, and when it should be uncommented?
biodranik commented 2023-04-15 15:41:33 +00:00 (Migrated from github.com)
Copy link

Why the size of categories is limited? We have complains from the carplay users about it.

Why the size of categories is limited? We have complains from the carplay users about it.
biodranik commented 2023-04-15 15:42:35 +00:00 (Migrated from github.com)
Copy link

It's better to use the following pattern:

TODO(name or initials or nickname): show that dialog
It's better to use the following pattern: ``` TODO(name or initials or nickname): show that dialog ```
biodranik commented 2023-04-15 15:43:23 +00:00 (Migrated from github.com)
Copy link

Is it a good idea to use annotations like NonNull, etc.?

Is it a good idea to use annotations like `NonNull`, etc.?
biodranik commented 2023-04-15 15:44:37 +00:00 (Migrated from github.com)
Copy link

@vng what do you think about moving { to a newline?

`@vng` what do you think about moving { to a newline?
biodranik commented 2023-04-15 15:46:01 +00:00 (Migrated from github.com)
Copy link

approved this merge request

approved this merge request
AndrewShkrob commented 2023-04-15 15:53:03 +00:00
Author
Member
Copy link

It is limited to MAX_CATEGORIES_SIZE according to the AA restrictions.
https://developer.android.com/reference/androidx/car/app/constraints/ConstraintManager

It is limited to `MAX_CATEGORIES_SIZE` according to the AA restrictions. https://developer.android.com/reference/androidx/car/app/constraints/ConstraintManager
AndrewShkrob commented 2023-04-15 16:03:32 +00:00
Author
Member
Copy link

Btw, that's why I created CATEGORIES list. We should discuss what categories (and their priority) should be displayed on this screen.

Btw, that's why I created `CATEGORIES` list. We should discuss what categories (and their priority) should be displayed on this screen.
vng commented 2023-04-17 17:53:44 +00:00 (Migrated from github.com)
Copy link

Ту не будет проблем? Где вызывается эта getBookmarks() ?

Ту не будет проблем? Где вызывается эта getBookmarks() ?
vng commented 2023-04-17 17:55:08 +00:00 (Migrated from github.com)
Copy link

approved this merge request

approved this merge request
AndrewShkrob commented 2023-04-17 17:58:22 +00:00
Author
Member
Copy link

А какие проблемы могут быть? В createBookmarkCategoriesList()

А какие проблемы могут быть? В `createBookmarkCategoriesList()`
vng commented 2023-04-17 18:06:16 +00:00 (Migrated from github.com)
Copy link

Если мы не будем показывает в списке невидимые категории, то как юзер их сделает видимыми?
Сейчас видимость - это галка чекбокса в андроид. Или я не прав тут?

Если мы не будем показывает в списке невидимые категории, то как юзер их сделает видимыми? Сейчас видимость - это галка чекбокса в андроид. Или я не прав тут?
AndrewShkrob commented 2023-04-17 18:12:18 +00:00
Author
Member
Copy link

Если юзер хочет сделать категорию видимой, то пусть это делает через телефон
AA - это же компаньон. Тут только основной функционал должен быть.

Если юзер хочет сделать категорию видимой, то пусть это делает через телефон AA - это же компаньон. Тут только основной функционал должен быть.
vng commented 2023-04-17 18:17:29 +00:00 (Migrated from github.com)
Copy link

А ну ок, я не увидел /car/screens/ :)

А ну ок, я не увидел /car/screens/ :)
biodranik commented 2023-04-17 20:25:36 +00:00 (Migrated from github.com)
Copy link

Можно посмотреть, что предлагают гугл с эплом, и добавить туда туалеты )

А вообще, главное это заправки и rest area.

Можно посмотреть, что предлагают гугл с эплом, и добавить туда туалеты ) А вообще, главное это заправки и rest area.
biodranik (Migrated from github.com) approved these changes 2025-03-22 17:52:54 +00:00
vng (Migrated from github.com) approved these changes 2025-03-22 17:52:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
biodranik
vng
Labels
Clear labels   
Accessibility

   
Address

   
Android

   
Android Auto

   
Android Automotive (AAOS)

   
API

   
AppGallery

   
AppStore

   
Battery and Performance

   
Blocker

   
Bookmarks and Tracks

   
Borders

   
Bug

   
Build

   
CarPlay

   
Classificator

   
Community

   
Core

   
CrashReports

   
Cycling

   
Desktop

   
DevEx

   
DevOps

   
dev_sandbox

   
Directions

   
Documentation

   
Downloader

   
Drape

   
Driving

   
Duplicate

   
Editor

   
Elevation

   
Enhancement

   
Epic

   
External Map Datasets

   
F-Droid

   
Fonts

   
Frequently User Reported

   
Fund

   
Generator

   
Good first issue

   
Google Play

   
GPS

   
GSoC

   
iCloud

   
Icons

   
iOS

   
Legal

   
Linux Desktop

   
Linux packaging

   
Linux Phone

   
Mac OS

   
Map Data

   
Metro

   
Navigation

   
Need Feedback

   
Night Mode

   
NLnet 2024-06-281

   
No Feature Parity

   
Opening Hours

   
Outdoors

   
POI Info

   
Privacy

   
Public Transport

   
Raw Idea

   
Refactoring

   
Regional

   
Regression

   
Releases

   
RoboTest

   
Route Planning

   
Routing

   
Ruler

   
Search

   
Security

   
Styles

   
Tests

   
Track Recording

   
Translations

   
TTS

   
UI

   
UX

   
Walk Navigation

   
Watches

   
Web

   
Wikipedia

   
Windows

   
Won't fix

   
World Map
No labels
Accessibility
Address
Android
Android Auto
Android Automotive (AAOS)
API
AppGallery
AppStore
Battery and Performance
Blocker
Bookmarks and Tracks
Borders
Bug
Build
CarPlay
Classificator
Community
Core
CrashReports
Cycling
Desktop
DevEx
DevOps
dev_sandbox
Directions
Documentation
Downloader
Drape
Driving
Duplicate
Editor
Elevation
Enhancement
Epic
External Map Datasets
F-Droid
Fonts
Frequently User Reported
Fund
Generator
Good first issue
Google Play
GPS
GSoC
iCloud
Icons
iOS
Legal
Linux Desktop
Linux packaging
Linux Phone
Mac OS
Map Data
Metro
Navigation
Need Feedback
Night Mode
NLnet 2024-06-281
No Feature Parity
Opening Hours
Outdoors
POI Info
Privacy
Public Transport
Raw Idea
Refactoring
Regional
Regression
Releases
RoboTest
Route Planning
Routing
Ruler
Search
Security
Styles
Tests
Track Recording
Translations
TTS
UI
UX
Walk Navigation
Watches
Web
Wikipedia
Windows
Won't fix
World Map
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps#4989
No description provided.
Delete branch "github/fork/AndrewShkrob/android-auto/refactoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?