organicmaps/organicmaps

Fork 24

[android] Add explicit check for PointChooserMode #6437

Merged

root merged 1 commit from rt-android-editor-position-chooser into master

2023-11-06 06:48:00 +00:00

rtsisyk commented

2023-11-01 07:21:30 +00:00

Owner

It is not clear how to reproduce this bug. Add a workaround and a log entry.

See #3945
See #3593

It is not clear how to reproduce this bug. Add a workaround and a log entry. See #3945 See #3593

biodranik commented

2023-11-01 23:44:34 +00:00

(Migrated from github.com)

Let's explicitly crash here to find and fix the bug reason.

rtsisyk commented

2023-11-05 18:58:40 +00:00

Author

Owner

It is pretty obvious that in #3945 the app started with Framework.nativeIsInChoosePositionMode() && mPointChooserMode == PointChooserMode.NONE. I don't know why. This state is managed somewhere in the native editor.

It is pretty obvious that in #3945 the app started with `Framework.nativeIsInChoosePositionMode() && mPointChooserMode == PointChooserMode.NONE`. I don't know why. This state is managed somewhere in the native editor.

rtsisyk commented

2023-11-05 18:59:08 +00:00

Author

Owner

changed title from [android] Add {-a workaround for a crash in Editor-} to [android] Add {+explicit check for PointChooserMode+}

changed title from **[android] Add {-a workaround for a crash in Editor-}** to **[android] Add {+explicit check for PointChooserMode+}**

rtsisyk commented

2023-11-05 18:59:50 +00:00

Author

Owner

requested review from @biodranik

requested review from `@biodranik`

biodranik commented

2023-11-05 19:01:41 +00:00

(Migrated from github.com)

Review: Approved

Is it the best way to debug it?

**Review:** Approved Is it the best way to debug it?

biodranik commented

2023-11-05 19:01:41 +00:00

(Migrated from github.com)

approved this merge request

rtsisyk closed this pull request

2023-11-06 06:48:00 +00:00

rtsisyk merged commit into master

2023-11-06 06:48:00 +00:00

rtsisyk commented

2023-11-06 06:48:19 +00:00

Author

Owner

Is it the best way to debug it?

Let's try to reproduce first.

> Is it the best way to debug it? Let's try to reproduce first.

Jean-BaptisteC commented

2023-11-13 21:16:01 +00:00

Member

@rtsisyk
I'm able to reproduce on latest beta and debug version from master :)

Open bottom menu
Add new place on map
Rotate device-> crash

mPointChooserMode is reset when we rotate the device?

`@rtsisyk` I'm able to reproduce on latest beta and debug version from master :) - Open bottom menu - Add new place on map - Rotate device-> crash mPointChooserMode is reset when we rotate the device?

rtsisyk commented

2023-11-17 07:50:15 +00:00

Author

Owner

mentioned in merge request !6586