Unify IsPoiChecker and use it for 'operator'. #8595
No reviewers
Labels
No labels
Accessibility
Address
Android
Android Auto
Android Automotive (AAOS)
API
AppGallery
AppStore
Battery and Performance
Blocker
Bookmarks and Tracks
Borders
Bug
Build
CarPlay
Classificator
Community
Core
CrashReports
Cycling
Desktop
DevEx
DevOps
dev_sandbox
Directions
Documentation
Downloader
Drape
Driving
Duplicate
Editor
Elevation
Enhancement
Epic
External Map Datasets
F-Droid
Fonts
Frequently User Reported
Fund
Generator
Good first issue
Google Play
GPS
GSoC
iCloud
Icons
iOS
Legal
Linux Desktop
Linux packaging
Linux Phone
Mac OS
Map Data
Metro
Navigation
Need Feedback
Night Mode
NLnet 2024-06-281
No Feature Parity
Opening Hours
Outdoors
POI Info
Privacy
Public Transport
Raw Idea
Refactoring
Regional
Regression
Releases
RoboTest
Route Planning
Routing
Ruler
Search
Security
Styles
Tests
Track Recording
Translations
TTS
UI
UX
Walk Navigation
Watches
Web
Wikipedia
Windows
Won't fix
World Map
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: organicmaps/organicmaps#8595
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "vng-fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Merge after the upcoming release.
requested review from
@biodranik
requested review from
@pastk
requested review from
@dvdmrtnz
mentioned in merge request !8523
This reduces the number of asm instructions by two. Unfortunately, compilers are not smart :(
Are there threeLevel types? Are they POI?
Hmm, maybe there was a reason "operator" was picked up for certain POIs only - probably only for those where it should highly likely make sense.
E.g. a particular restaurant in a franchise chain could be operated by some small/unknown company. See https://wiki.openstreetmap.org/wiki/Key:operator#Examples
It is a follow-up from here and here
You can open a discussion there :)
I did :)
I also have mixed feelings about widely used 'operator' and 'network' tags, but POIs look like a reasonable tradeoff.
What are the typical values in some well-mapped city? Let's see if they're useful for POIs.
Ok, while the discussion is still open, I made like before (operator selector) plus "university", "vending_machine" (from the issue).
The issue mentioned public transport ticket vending machines - makes sense.
Re other vending machines (e.g. drinks, coffee) it could be some small unknown companies operating them... But IDK really.
It'd be good if someone makes a tagging research.
Or we can push it to alpha and ask for feedback.
Review: Approved
Technically it looks good!
approved this merge request
Is it easy to limit the vending machines change to
amenity-vending_machine-public_transport_tickets
only?Changes look good, only one comment about this:
In #8039 the user actually wanted to be able to see the operator of buildings operated by a university. So these buildings would not be tagged with
amenity=university
but withbuilding
.I understand that most building's operators are going to be irrelevant for users, so maybe only show operator for university-related buildings like
building=dormitory
,building=university
?mentioned in issue #5219
mentioned in issue #9652