Unify IsPoiChecker and use it for 'operator'. #8595

Merged
vng merged 4 commits from vng-fix into master 2024-07-07 01:48:41 +00:00
vng commented 2024-06-29 18:05:49 +00:00 (Migrated from github.com)

Merge after the upcoming release.

Merge after the upcoming release.
vng commented 2024-06-29 18:05:49 +00:00 (Migrated from github.com)

requested review from @biodranik

requested review from `@biodranik`
vng commented 2024-06-29 18:05:49 +00:00 (Migrated from github.com)

requested review from @pastk

requested review from `@pastk`
vng commented 2024-06-29 18:05:49 +00:00 (Migrated from github.com)

requested review from @dvdmrtnz

requested review from `@dvdmrtnz`
vng commented 2024-06-29 18:07:17 +00:00 (Migrated from github.com)

mentioned in merge request !8523

mentioned in merge request !8523
biodranik commented 2024-06-29 18:19:54 +00:00 (Migrated from github.com)
  auto const paths = {
```suggestion:-0+0 auto const paths = { ```
biodranik commented 2024-06-29 18:20:38 +00:00 (Migrated from github.com)

This reduces the number of asm instructions by two. Unfortunately, compilers are not smart :(

  for (auto const * path : paths)
This reduces the number of asm instructions by two. Unfortunately, compilers are not smart :( ```suggestion:-0+0 for (auto const * path : paths) ```
biodranik commented 2024-06-29 18:23:06 +00:00 (Migrated from github.com)

Are there threeLevel types? Are they POI?

Are there threeLevel types? Are they POI?
Member

Hmm, maybe there was a reason "operator" was picked up for certain POIs only - probably only for those where it should highly likely make sense.

E.g. a particular restaurant in a franchise chain could be operated by some small/unknown company. See https://wiki.openstreetmap.org/wiki/Key:operator#Examples

Hmm, maybe there was a reason "operator" was picked up for certain POIs only - probably only for those where it should highly likely make sense. E.g. a particular restaurant in a franchise chain could be operated by some small/unknown company. See https://wiki.openstreetmap.org/wiki/Key:operator#Examples
vng commented 2024-06-29 18:56:27 +00:00 (Migrated from github.com)

It is a follow-up from here and here

You can open a discussion there :)

It is a follow-up from [here](https://git.omaps.dev/organicmaps/organicmaps/pulls/8523) and [here](https://git.omaps.dev/organicmaps/organicmaps/issues/8039) You can open a discussion there :)
Member

I did :)

I did :)
vng commented 2024-06-29 19:02:13 +00:00 (Migrated from github.com)

I also have mixed feelings about widely used 'operator' and 'network' tags, but POIs look like a reasonable tradeoff.

I also have mixed feelings about widely used 'operator' and 'network' tags, but POIs look like a reasonable tradeoff.
biodranik commented 2024-06-29 19:39:54 +00:00 (Migrated from github.com)

What are the typical values in some well-mapped city? Let's see if they're useful for POIs.

What are the typical values in some well-mapped city? Let's see if they're useful for POIs.
vng commented 2024-06-29 22:07:18 +00:00 (Migrated from github.com)

Ok, while the discussion is still open, I made like before (operator selector) plus "university", "vending_machine" (from the issue).

Ok, while the discussion is still open, I made like before (operator selector) plus "university", "vending_machine" (from the issue).
Member

The issue mentioned public transport ticket vending machines - makes sense.

Re other vending machines (e.g. drinks, coffee) it could be some small unknown companies operating them... But IDK really.
It'd be good if someone makes a tagging research.
Or we can push it to alpha and ask for feedback.

The issue mentioned public transport ticket vending machines - makes sense. Re other vending machines (e.g. drinks, coffee) it could be some small unknown companies operating them... But IDK really. It'd be good if someone makes a tagging research. Or we can push it to alpha and ask for feedback.
Member

Review: Approved

Technically it looks good!

**Review:** Approved Technically it looks good!
Member

approved this merge request

approved this merge request
Member

The issue mentioned public transport ticket vending machines - makes sense.

Re other vending machines (e.g. drinks, coffee) it could be some small unknown companies operating them...

Is it easy to limit the vending machines change to amenity-vending_machine-public_transport_tickets only?

> The issue mentioned public transport ticket vending machines - makes sense. > > Re other vending machines (e.g. drinks, coffee) it could be some small unknown companies operating them... Is it easy to limit the vending machines change to `amenity-vending_machine-public_transport_tickets` only?
Contributor

Changes look good, only one comment about this:

Ok, while the discussion is still open, I made like before (operator selector) plus "university", "vending_machine" (from the issue).

In #8039 the user actually wanted to be able to see the operator of buildings operated by a university. So these buildings would not be tagged with amenity=university but with building.

I understand that most building's operators are going to be irrelevant for users, so maybe only show operator for university-related buildings like building=dormitory, building=university ?

Changes look good, only one comment about this: > Ok, while the discussion is still open, I made like before (operator selector) plus "university", "vending_machine" (from the issue). In https://git.omaps.dev/organicmaps/organicmaps/issues/8039 the user actually wanted to be able to see the operator of buildings operated by a university. So these buildings would not be tagged with `amenity=university` but with `building`. I understand that most building's operators are going to be irrelevant for users, so maybe only show operator for university-related buildings like `building=dormitory`, `building=university` ?
vng (Migrated from github.com) closed this pull request 2024-07-07 01:48:41 +00:00
vng (Migrated from github.com) merged commit into master 2024-07-07 01:48:41 +00:00
Contributor

mentioned in issue #5219

mentioned in issue #5219
Member

mentioned in issue #9652

mentioned in issue #9652
pastk approved these changes 2025-03-22 17:37:54 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps#8595
No description provided.