organicmaps/subways
13
Fork 0
Code Issues Pull requests 1 Projects Releases Wiki Activity Actions
247 commits 4 branches 0 tags 1.9 MiB
Commit graph

247 commits

This branch
This branch
All branches
Author SHA1 Message Date
Alexey Zakharenkov
e27fdd8c2d Add to GTFS only transfers in which both stops are part of routes 2023-03-14 19:15:44 +01:00
Alexey Zakharenkov
909c7b3c70 Refactoring: make main() function and two more functions 2023-03-14 19:15:44 +01:00
Alexey Zakharenkov
a6adb9f0b5 More accurate OSM element centers calculation 2023-03-14 19:15:44 +01:00
Alexey Zakharenkov
9f2b141277 Remove duplicate variable assignment 2023-03-14 19:15:44 +01:00
Alexey Zakharenkov
4bb99a37ea Refactoring: move a nested function to the module level; add tests for it 2023-03-14 19:15:44 +01:00
Alexey Zakharenkov
cf0ce1c55e Add two new checks 2023-03-14 19:15:44 +01:00
Alexey Zakharenkov
45f247d793 Create method to allow overriding 2023-03-14 19:15:44 +01:00
Alexey Zakharenkov
89e4d5c261 Take into account that City.validate() method may never be called for a city - in case a CriticalValidationError occured 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
aab668f550 Validation error 'Stop ... is nowhere near the tracks' was mistakenly supressed and now returned 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
0478791cf2 Fix attribute assignment 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
ee913b6d2d Fixes to GTFS generation 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
82707f8528 Make City.is_good a property 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
d88755de99 Use csv.DictReader instead of csv.reader to load city data 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
123d0f96d3 Add tests on adjusting rails geometry; configure GitHub Actions for the tests 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
28c455d368 Methods to adjust rails at route start/end 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
78304da88f Refactor Route.__init_() to separate stops processing from rails processing 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
2224b9f318 GTFS output 2023-03-14 19:15:43 +01:00
Alexey Zakharenkov
fd27851c0b Revert PR #18 as incorrect: there may be lines with the same ref in a network 2023-03-14 19:15:43 +01:00
Jiaxun Yang
7072494bbd Suggest the parent route of platform with invalid role 
The wraning message now looks like: 
Platform "" (w1055889735) with invalid role '' in route (relation 2336456, "")
It will be easier for us to sort those issues.
 2023-03-14 19:15:43 +01:00
Alexander Borsuk
738e13d73a Create directories if necessary 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2022-04-23 00:32:38 +02:00
Alexander Borsuk
263329e06d Updated README 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2022-04-23 00:28:48 +02:00
Alexander Borsuk
7537e2aace
Merge pull request #3 from organicmaps/upstream 
Upstream fixes
 2022-04-23 00:26:36 +02:00
Alexey Zakharenkov
7df15a390d Check route ref uniqueness within a city 2022-04-21 19:19:33 +03:00
Alexey Zakharenkov
d28b2f1503 Make "Route has no stops" a warning, not an error 2022-04-21 14:24:42 +03:00
Alexey Zakharenkov
bf27197b12 Correct links to the repository and active validator instance 2021-11-20 21:06:42 +01:00
Alexey Zakharenkov
9246f72998 Correct links to the repository and active validator instance 2021-11-19 12:56:33 +03:00
Alexander Borsuk
92430e27fc
Merge pull request #1 from alexey-zakharenkov/master 
Changes from the upstream repo
 2021-11-12 21:36:31 +01:00
Alexey Zakharenkov
de63a46e5c
Merge pull request #14 from alexey-zakharenkov/add-error-severity-level 
Make three levels of severity for validation messages
 2021-11-09 18:35:55 +03:00
Alexey Zakharenkov
ef5bbab672 Return "error_if"-logic for tram lines count 2021-11-08 12:22:57 +03:00
Alexey Zakharenkov
76d9d0bbb9 Fix html layout so that tooltips stay inside window viewport 2021-11-03 23:30:32 +03:00
Alexey Zakharenkov
9d4d6c6583 Merge branch 'master' into add-error-severity-level 2021-11-03 13:46:48 +03:00
Claudius
0bc8f779ae More user friendly UX for severity level messaging 
More user friendly severity level messaging

Included the changes I mentioned in [my earlier comment](https://github.com/alexey-zakharenkov/subways/pull/14#issuecomment-948391863) to:
- Add section headers to the different severity level messages
- Change the errors red colour to a accessible one
- Changed copy of entrance errors from "e:" to "ent:"
- Shortened an error message slightly to reduce possibility of it wrapping into a new line and have the "Under construction" keyword at the beginning of the sentence

CSS property width=fit-content is not supported in Firefox; shorten tooltip text; exclude empty validation message during HTML genertion
 2021-11-03 10:56:10 +01:00
Claudius
a397360f43
Merge pull request #11 from claudiush/master 
Always visible footer and improved hover colours
 2021-10-22 09:34:07 +02:00
Alexey Zakharenkov
0a1115f4ec Make three levels of severity for validation errors 2021-10-16 00:50:02 +03:00
Claudius
2cb5e84694 Update v2h_templates.py 
Tweaks to the HTML output template:
- Sticky footer so update timestamp always visible without scrolling
- Slight copy update to clarify that networks are shown behind the map link
- table row hover state now uses hue-rotate to ensure enough contrast as compared to whole line blue previously
 2021-10-06 12:03:36 +02:00
Victor Popov
03e3333ec9 Workaround osmtools bugs with tempfiles 
- Osmupdate does not pass tempfiles settings to osmconvert call,
  so ensure that current working dir is writable before launching osmupdate.
- Explicitly specify tempfiles location for osmfilter call.
 2021-09-30 16:57:45 +03:00
Victor Popov
dd833f6639 Explicitly specify osmconvert tempfiles location 2021-09-30 09:17:42 +03:00
Victor Popov
4f8f7416f3 Various improvements 
- Introduce PLANET_UPDATE_SERVER environment variable to allow
  overriding of default https://planet.openstreetmap.org/replication/
  update source.
- Explicitly specify path to temp files for osmupdate.
- Improve error handling in case when osmupdate fails: capture output
  and echo them (otherwise bash exits due to `set -e`)
- check_osmctools before using osmtools. This fixes error if both
  SKIP_PLANET_UPDATE and PLANET_METRO are specified.
 2021-09-29 12:05:29 +03:00
Victor Popov
90597822f3 Add requirements.txt file for project, to be able to use virtual environments 2021-09-10 14:40:50 +03:00
Alexey Zakharenkov
6596d9789c PEPify-8 with black -l 79 -S 2021-08-02 15:45:56 +03:00
Alexey Zakharenkov
b422ccb6ad Use argparse module in mapsme_json_to_cities.py 2021-08-02 15:45:56 +03:00
Alexey Zakharenkov
2dfb2e46e0 Get rid of obsolete --bbox parameter for process_subways.py 2021-08-02 15:45:56 +03:00
Alexey Zakharenkov
2734f9fd9e Update README 2021-08-02 15:45:56 +03:00
Alexey Zakharenkov
44c6dc77e4 Elaborate planet processing pipeline 2021-08-02 15:45:56 +03:00
Alexey Zakharenkov
4884c711c2 mapsme_json_to_cities.py script 2021-08-02 15:45:56 +03:00
Alexey Zakharenkov
724a9344a9 Add 'POLY' parameter to bash script and a script to generate a *.poly file with metro bbox union 2021-08-02 15:45:56 +03:00
Alexey Zakharenkov
cc0fee6167
Update subway_structure.py 2021-04-20 00:24:41 +03:00
Alexey Zakharenkov
e64fbbee97 Fixes after review 2020-10-13 11:21:56 +03:00
Alexey Zakharenkov
14e96bb806 While checking stops order on tracks, take into account repeated tracks/stations in a route like Line 5 of Oslo metro or spoon-shaped Line 7bis in Paris 2020-10-13 11:21:56 +03:00
Alexey Zakharenkov
6eb7ec8586 While checking stops order on tracks, take into account that more than one stop can reside on the same track segment 2020-10-13 11:21:56 +03:00