organicmaps/twine
Archived
13
Fork 0
Code Issues 1 Pull requests 2 Projects Releases Wiki Activity Actions

Report all errors, not just the first

Browse source
This commit is contained in:
Ben Cochran 2015-03-17 02:21:43 -07:00
parent ee2e679c4a
commit 2bdf42f399
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/twine/runner.rb
View file

@ -238,6 +238,7 @@ module Twine
all_keys = Set.new
duplicate_keys = Set.new
keys_without_tags = Set.new
errors = []
@strings.sections.each do |section|
section.rows.each do |row|
@ -257,14 +258,18 @@ module Twine
if duplicate_keys.length > 0
error_body = duplicate_keys.to_a.join("\n ")
raise Twine::Error.new "Found duplicate string key(s):\n #{error_body}"
errors << "Found duplicate string key(s):\n #{error_body}"
end
if keys_without_tags.length == total_strings
raise Twine::Error.new "None of your strings have tags."
errors << "None of your strings have tags."
elsif keys_without_tags.length > 0
error_body = keys_without_tags.to_a.join("\n ")
raise Twine::Error.new "Found strings(s) without tags:\n #{error_body}"
errors << "Found strings(s) without tags:\n #{error_body}"
end
if errors.length > 0
raise Twine::Error.new errors.join("\n\n")
end
puts "#{@options[:strings_file]} is valid."