organicmaps/twine
Archived
13
Fork 0
Code Issues 1 Pull requests 2 Projects Releases Wiki Activity Actions
324 commits 10 branches 23 tags 1 MiB
Commit graph

324 commits

This branch
This branch
All branches
Author SHA1 Message Date
Sebastian Ludwig
d8387e55f4 Added unit test to verify empty sections don't contribute to jQuery formatter output. 2016-05-03 23:25:44 +02:00
Matthew Abbott
06cd167f2b Remote empty sections before joining them together 
Previously, a comma was being printed on the last line of every section, even if
that section did not contribute any rows to the formatted output (e.g., no rows
within that section had the tags needed to be output during this run). When such
a zero-row section happens, it results in an line with only a comma on it, which
is not valid json. This can make incremental adjustment of the jquery files
rather tedious, even when using gui tools to quickly reject changes.
 2016-05-03 23:11:47 +02:00
Sebastian Celis
50b1e90f8f Merge pull request #158 from sebastianludwig/test_improvements 
Test improvements
 2016-05-03 15:54:14 -05:00
Sebastian Ludwig
2e283d7057 Got rid of the Case in test class names. 2016-05-03 22:44:22 +02:00
Sebastian Celis
b779e112ff Merge pull request #160 from PaulWagener/django-utf8 
Add UTF-8 Content-Type to the Django formatter
 2016-05-03 15:09:54 -05:00
Paul Wagener
111840ed70 Add UTF-8 Content-Type to the Django formatter 2016-05-03 21:53:12 +02:00
Sebastian Celis
be5bb1f4b6 Merge pull request #159 from sebastianludwig/fix_81 
Fixed #81
 2016-04-27 09:11:45 -05:00
Sebastian Ludwig
ea58bd10ca Properly parsing multiline strings in Android formatter by using REXML instead of regexps. Fixes #81. 2016-04-27 08:35:52 +02:00
Sebastian Celis
0a96b11099 Merge pull request #157 from sebastianludwig/fix_155 
Fixed #155 by removing mapping from zh to zh-Hans in Android formatter.
 2016-04-26 15:37:28 -05:00
Sebastian Ludwig
f4cbf08122 Fixed #155 by removing mapping from zh to zh-Hans in Android formatter. 2016-04-26 21:11:34 +02:00
Sebastian Celis
b47ab9369b Improve tags section. 
This fixes #152.
 2016-04-05 07:45:49 -05:00
Sebastian Celis
a03c6b5e58 Merge pull request #149 from sebastianludwig/documentation 
Added documentation assets.
 2016-04-04 11:39:30 -05:00
Sebastian Ludwig
8d4246b8b1 Added formatter documentation as markdown file. 2016-04-03 23:08:18 +02:00
Sebastian Celis
1e1b73fda2 Merge pull request #147 from sebastianludwig/naming 
Better naming
 2016-04-03 14:06:54 -04:00
Sebastian Ludwig
ce5c9a1828 Incorporated PR feedback. 2016-04-02 10:59:53 +02:00
Sebastian Celis
035afe3df3 Be explicit when requiring formatters. 
I think I prefer this explicitness over the prior
automatic importing code. It feels safer (it won't
load files that are placed into the formatters
folder that shouldn't be there) and it avoids the
issue we had in #145 where formatters can load in
arbitrary order.
 2016-04-01 15:58:57 -04:00
Sebastian Celis
ae31911a62 Update version to 0.9.1 2016-04-01 15:31:32 -04:00
Sebastian Ludwig
8a8e2d992f Added documentation assets. 2016-03-31 22:48:08 +02:00
Sebastian Ludwig
ef84dd322c Renamed commands to get rid of more 'string' ambiguities. 2016-03-31 22:36:06 +02:00
Sebastian Ludwig
b1b59f4f62 Updated README 2016-03-31 22:36:06 +02:00
Sebastian Ludwig
594fbfddcc Renamed StringsFile to TwineFile, StringsSection to TwineSection and StringsRow to TwineDefinition. 2016-03-31 22:36:06 +02:00
Sebastian Celis
043836e84f Merge pull request #148 from sebastianludwig/ubuntu_fix 
Fixed #145
 2016-03-31 10:04:44 -04:00
Sebastian Ludwig
00a8907646 Fixed #145 by requiring abstract formatter before requiring any other formatter to ensure it's loaded first, in case files are not required in alphabetical order. 2016-03-31 14:30:55 +02:00
Sebastian Celis
d026c65f44 Merge pull request #146 from paulvi/patch-1 
README - colorize example
 2016-03-22 09:23:57 -05:00
Paul Verest
014a6a36ca README - colorize example 2016-03-22 09:26:29 +08:00
Sebastian Celis
0f0373ac43 Update version to 0.9.0 2016-03-02 14:48:00 -06:00
Sebastian Celis
9e40525df8 Merge pull request #143 from sebastianludwig/option_parsing 
Better option parsing
 2016-03-02 08:52:19 -06:00
Sebastian Ludwig
4e0eeaa9f1 Relying on and using more features of OptionParser and improved --help formatting. 2016-03-01 16:20:44 -06:00
Sebastian Celis
dee066303b Merge pull request #142 from sebastianludwig/unified_reading 
Unified reading
 2016-03-01 16:08:17 -06:00
Sebastian Ludwig
e59f33c882 Fixed #137 by allowing unquoted keys in Apple string files. 2016-03-01 15:41:59 -06:00
Sebastian Ludwig
9e7e51e4c6 Moved heavily redundant file opening logic (necessary to read string files) from formatters to Runner and unified the encoding handling. 2016-03-01 12:56:42 -06:00
Sebastian Ludwig
7124b36b2d Removed Ruby 1.9 leftovers since Twine requires Ruby 2.0. 2016-03-01 12:56:20 -06:00
Sebastian Ludwig
feea61744c Cleaned up Runner::consume_loc_drop 2016-03-01 12:38:26 -06:00
Sebastian Celis
e690be4eee Merge pull request #141 from sebastianludwig/android_output_folders 
Properly prefixing Android output path
 2016-02-29 09:14:18 -06:00
Sebastian Celis
4be87b8d3f Merge pull request #140 from sebastianludwig/empty_results 
Empty results
 2016-02-29 09:12:37 -06:00
Sebastian Ludwig
f29d73c6fa Properly prefixing Android output path with values-. 2016-02-28 11:58:33 -06:00
Sebastian Ludwig
1aa45c0c75 Logging a warning, if a file is skipped because it would be empty while generating a loc drop. 2016-02-28 11:42:55 -06:00
Sebastian Ludwig
eec7d3b5d2 Logging a warning, if a file is skipped because it would be empty while generating all string files. 2016-02-28 09:18:51 -06:00
Sebastian Ludwig
d7dfe19512 Moved write_all_files from Abstract formatter to Runner. 2016-02-28 09:14:25 -06:00
Sebastian Ludwig
430bc1bac2 Raising an error if generate_string_file would create an empty file. 2016-02-28 09:14:25 -06:00
Sebastian Ludwig
1e63a89860 Inlined method that was only used once. 2016-02-28 09:14:25 -06:00
Sebastian Ludwig
0f2535223e Removed Abstract::write_file, since formatters should focus on formatting. format_file is used directly instead. 2016-02-27 19:49:01 -06:00
Sebastian Ludwig
3cb766d9a2 Renamed test cases to match the command line option they are testing (--validate). 2016-02-27 17:40:34 -06:00
Sebastian Ludwig
e5f9625105 Fixed typo. 2016-02-27 17:39:15 -06:00
Sebastian Celis
c863485b1d Merge pull request #136 from sebastianludwig/android_langauges 
Fixed Android language determination. Closes #134.
 2016-02-22 16:32:59 -06:00
Sebastian Ludwig
0a80890f87 Added more Android formatter language determination unit tests. 2016-02-22 16:31:24 -06:00
Sebastian Ludwig
e2dc6dce01 Fixed Android language determination. Closes #134. 2016-02-22 15:45:11 -06:00
Sebastian Celis
8700257f95 Update version to 0.8.1. 2016-02-22 09:32:52 -06:00
Sebastian Celis
3c1a931404 Merge pull request #133 from sebastianludwig/duplicate_strings 
Duplicate strings
 2016-02-22 09:32:17 -06:00
Sebastian Ludwig
9374fdb40a Converted otherwise unused instance variables to local variables. 2016-02-22 09:12:03 -06:00