preview page: update buttons #1

2022-01-09T23:31:14Z

alatarum commented

2022-01-09 23:31:14 +00:00

(Migrated from github.com)

Use "geo:" link for open point action as more universal way to handle
coordinates
Hide "See on OpenStreetMap" button on mobile devices to simplify page
Show coordinates instead of point name (which can be seen in baloon)
Move "Get Organic Maps" button to footer

Signed-off-by: Andrei Kartashev a.s.kartashev@gmail.com

* Use "geo:" link for open point action as more universal way to handle coordinates * Hide "See on OpenStreetMap" button on mobile devices to simplify page * Show coordinates instead of point name (which can be seen in baloon) * Move "Get Organic Maps" button to footer Signed-off-by: Andrei Kartashev <a.s.kartashev@gmail.com>

biodranik commented

2022-01-10 15:42:29 +00:00

(Migrated from github.com)

There are several issues:

Too much space is taken by green headers. The map should be the priority, not a green color on top of it.
Zoom buttons are under the footer.
Footer takes a lot of space and doesn't look good. It's better to put all buttons in one line at the top, and properly format them.
geo:// link instead of plain coordinates should be displayed on mobile devices to allow open links in other maps.

There are several issues: 1. Too much space is taken by green headers. The map should be the priority, not a green color on top of it. 2. Zoom buttons are under the footer. 3. Footer takes a lot of space and doesn't look good. It's better to put all buttons in one line at the top, and properly format them. 4. geo:// link instead of plain coordinates should be displayed on mobile devices to allow open links in other maps.

alatarum commented

2022-02-06 20:59:10 +00:00

(Migrated from github.com)

I decide to return to initial layout, but cleanup it a bit.

biodranik (Migrated from github.com) reviewed 2022-02-14 20:42:10 +00:00

public/ge0.html

					
				@ -221,3 +126,2 @@

				    var marker = L.marker([lat, lon], {icon: POI_Icon}).addTo(map);

				    marker.bindPopup('${name}');//.openPopup();

				    const marker = L.marker([lat, lon]).addTo(map);

biodranik (Migrated from github.com) commented

2022-02-14 20:42:10 +00:00

No, we can not remove om:// link. It is the only way to open https://omaps.app links on many androids and iOS devices where it's not open by default from the app.

alatarum (Migrated from github.com) reviewed 2022-02-18 20:41:00 +00:00

public/ge0.html

					
				@ -221,3 +126,2 @@

				    var marker = L.marker([lat, lon], {icon: POI_Icon}).addTo(map);

				    marker.bindPopup('${name}');//.openPopup();

				    const marker = L.marker([lat, lon]).addTo(map);

alatarum (Migrated from github.com) commented

2022-02-18 20:41:00 +00:00

Is it? I was sure "geo:" link is enough, since it shows "open with" dialog where one can choose OM or any other application.

biodranik (Migrated from github.com) reviewed 2022-02-19 13:24:53 +00:00

public/ge0.html

biodranik (Migrated from github.com) commented

2022-02-19 13:22:58 +00:00

    let coords = '${lat}, ${lon}';

```suggestion let coords = '${lat}, ${lon}'; ```

public/ge0.html

biodranik (Migrated from github.com) commented

2022-02-19 13:24:07 +00:00

Why is it removed for mobiles?

alatarum (Migrated from github.com) reviewed 2022-02-20 08:17:29 +00:00

public/ge0.html

alatarum (Migrated from github.com) commented

2022-02-20 08:17:29 +00:00

I believe, there is no any value to open OSM in browser on mobile when you have geo link. My initial intention was to minimize number of interface elements since now it look overloaded.

alatarum (Migrated from github.com) reviewed 2022-02-20 08:21:25 +00:00

public/ge0.html

alatarum (Migrated from github.com) commented

2022-02-20 08:21:25 +00:00

Are you sure, we should show coordinates without any keywords? I tried it first, but looks a bit ugly....

biodranik (Migrated from github.com) reviewed 2022-02-20 08:53:10 +00:00

public/ge0.html

biodranik (Migrated from github.com) commented

2022-02-20 08:53:10 +00:00

The main goal of this stub is to allow users to see the POI and open it anywhere. Overloading is not important, opening and understanding what POI was shared is important.

The main goal of this stub is to allow users to see the POI and open it _anywhere_. Overloading is not important, opening and understanding what POI was shared is important.