organicmaps/url-processor
13
Fork 0
Code Issues 2 Pull requests Projects Releases Wiki Activity Actions

Fixed windows-1251 names in the url #3

Merged
biodranik merged 1 commit from fix-vk-preview-urls into master 2023-05-06 07:45:31 +00:00
Conversation 3 Commits 1 Files changed 1 +25 -1
biodranik commented 2022-10-06 12:03:06 +00:00 (Migrated from github.com)
Copy link

Fixes wrongly encoded non-ascii symbols in the POI name when someone shares it using VK

Fixes wrongly encoded non-ascii symbols in the POI name when someone shares it using VK
biodranik commented 2023-05-04 22:50:56 +00:00 (Migrated from github.com)
Copy link

@rtsisyk 7 months ping. Please merge #7 first.

@rtsisyk 7 months ping. Please merge #7 first.
rtsisyk commented 2023-05-05 09:08:45 +00:00 (Migrated from github.com)
Copy link

Could you please provide any examples/test cases of URLs decoded?

Could you please provide any examples/test cases of URLs decoded?
biodranik commented 2023-05-06 05:28:03 +00:00 (Migrated from github.com)
Copy link

@rtsisyk

http://omaps.app/s5kfPG8Hgl/%C1%E5%EB%E0%FF_%F1%EA%E0%EB%E0
https://omaps.app/s5kfPGxnKT/%CA%E5%EC%EF%E8%ED%E3

Test it locally on this branch with npx wrangler dev:

http://127.0.0.1:8787/s5kfPG8Hgl/%C1%E5%EB%E0%FF_%F1%EA%E0%EB%E0
https://127.0.0.1:8787/s5kfPGxnKT/%CA%E5%EC%EF%E8%ED%E3

@rtsisyk http://omaps.app/s5kfPG8Hgl/%C1%E5%EB%E0%FF_%F1%EA%E0%EB%E0 https://omaps.app/s5kfPGxnKT/%CA%E5%EC%EF%E8%ED%E3 Test it locally on this branch with `npx wrangler dev`: http://127.0.0.1:8787/s5kfPG8Hgl/%C1%E5%EB%E0%FF_%F1%EA%E0%EB%E0 https://127.0.0.1:8787/s5kfPGxnKT/%CA%E5%EC%EF%E8%ED%E3
rtsisyk (Migrated from github.com) approved these changes 2023-05-06 07:40:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
rtsisyk
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/url-processor#3
No description provided.
Delete branch "fix-vk-preview-urls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?