Use web URLs for reviews #186

rtsisyk · 2023-10-07T07:10:08Z

reinhart1010 commented

2023-10-07 07:10:08 +00:00

(Migrated from github.com)

This commit fixes https://github.com/organicmaps/organicmaps.github.io/issues/21 by replacing app store-specific URIs into website URLs which can be viewed by most platforms.

biodranik commented

2023-10-07 08:28:21 +00:00

(Migrated from github.com)

Thanks!

Does it work on Android, starting from 5.0? Is the play market opened immediately or via a web browser?
Can you please squash/sign your commits with DCO?

Thanks! 1. Does it work on Android, starting from 5.0? Is the play market opened immediately or via a web browser? 2. Can you please squash/sign your commits with [DCO](https://github.com/organicmaps/website/pulls/186/checks?check_run_id=17487794736)?

reinhart1010 commented

2023-10-07 08:41:01 +00:00

(Migrated from github.com)

Opening web links directly into apps is supported since Android 6.0, but the web URLs must be verified to be opened in Android 12 and later.

As of now the Google Play Store mobile site also offers "See in Play Store app" button to open the native app through intent: URIs.

Opening web links directly into apps is supported since Android 6.0, but the web URLs [must be verified](https://developer.android.com/training/app-links/) to be opened in Android 12 and later. As of now the Google Play Store mobile site also offers "See in Play Store app" button to open the native app through `intent:` URIs. | ![image](https://github.com/organicmaps/organicmaps.github.io/assets/17312341/d034b193-cd68-4102-afca-92aabe70873a) | ![image](https://github.com/organicmaps/organicmaps.github.io/assets/17312341/e896b7e5-7dc6-4128-8fca-9888b0bed3da) | |---|---|

biodranik commented

2023-10-07 13:20:15 +00:00

(Migrated from github.com)

It is not clear to me now whether will it work after the merge or not.

Can we detect if it's an Android device, and if it's Android 5, and replace URLs dynamically using JS?

It is not clear to me now whether will it work after the merge or not. Can we detect if it's an Android device, and if it's Android 5, and replace URLs dynamically using JS?

rtsisyk requested changes 2024-12-27 21:07:18 +00:00

templates/shortcodes/references.md

					
				@ -1,5 +1,5 @@

				[appgallery]: https://appgallery.huawei.com/#/app/C104325611?local={{ lang }} "{{ trans(key='install-appgallery', lang=lang) }}"

				[appgallery_review]: appmarket://details?id=app.organicmaps

				[appgallery_review]: https://appgallery.huawei.com/#/app/C104325611?local={{ lang }}

				[appstore]: https://apps.apple.com/app/organic-maps/id1567437057 "{{ trans(key='install-appstore', lang=lang) }}"

rtsisyk commented

2024-12-27 21:07:15 +00:00

local= doesn't seem to be working

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin reinhart1010/reinhart1010-patch-1:reinhart1010/reinhart1010-patch-1

git checkout reinhart1010/reinhart1010-patch-1

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master

git merge --no-ff reinhart1010/reinhart1010-patch-1

git checkout reinhart1010/reinhart1010-patch-1

git rebase master

git checkout master

git merge --ff-only reinhart1010/reinhart1010-patch-1

git checkout reinhart1010/reinhart1010-patch-1

git rebase master

git checkout master

git merge --no-ff reinhart1010/reinhart1010-patch-1

git checkout master

git merge --squash reinhart1010/reinhart1010-patch-1