Style improvements #26

Merged

dustdfg merged 2 commits from dustdfg-patch-1 into master

2022-01-10 07:25:21 +00:00

dustdfg commented

2022-01-10 06:26:10 +00:00

(Migrated from github.com)

Signed-off-by: DustDFG dfgdust@gmail.com

Signed-off-by: DustDFG <dfgdust@gmail.com>

biodranik commented

2022-01-10 06:40:07 +00:00

(Migrated from github.com)

Thanks! Can you please sign the commit (or PR's description, if you can't amend by any reason)? You need to add this line to commit's description:

Signed-off-by: Your Name <your@email>

Thanks! Can you please sign the commit (or PR's description, if you can't amend by any reason)? You need to add this line to commit's description: ``` Signed-off-by: Your Name <your@email> ```

dustdfg commented

2022-01-10 07:02:23 +00:00

(Migrated from github.com)

@biodranik It seems to me that I did it. Is it enough?

biodranik commented

2022-01-10 07:04:02 +00:00

(Migrated from github.com)

Aha, I see, only one commit is authored with DCO. All of them should be signed (or you/we can squash them).

dustdfg commented

2022-01-10 07:08:43 +00:00

(Migrated from github.com)

@biodranik I am a new user on GitHub and I don't understand what is DCO. How do I correct it without command-line?

biodranik commented

2022-01-10 07:20:38 +00:00

(Migrated from github.com)

@biodranik I am a new user on GitHub and I don't understand what is DCO. How do I correct it without command-line?

We use DCO to author commits because of legal issues. The only way to fix it without a command line is to add DCO line in the PR, so we can squash it during the merge.

> @biodranik I am a new user on GitHub and I don't understand what is DCO. How do I correct it without command-line? We use DCO to author commits because of legal issues. The only way to fix it without a command line is to add DCO line in the PR, so we can squash it during the merge.

biodranik (Migrated from github.com) approved these changes 2022-01-10 07:24:54 +00:00

biodranik (Migrated from github.com) left a comment

Thanks for the contribution!