organicmaps/website
13
Fork 1
Code Issues 31 Pull requests 8 Projects Releases Wiki Activity Actions

Add "Edit on Github" and "Translate to..." buttons #78

Open
biodranik wants to merge 2 commits from edit-translations-on-github into master
pull from: edit-translations-on-github
merge into: organicmaps:master
Conversation 11 Commits 2 Files changed 6 +150 -2
biodranik commented 2022-12-12 00:24:06 +00:00 (Migrated from github.com)
Copy link

Check the bottom of each page, there should be two buttons to easily edit the page or translate it to a new language.

Check the bottom of each page, there should be two buttons to easily edit the page or translate it to a new language.
vng (Migrated from github.com) reviewed 2022-12-12 00:24:06 +00:00
rtsisyk reviewed 2022-12-12 00:24:06 +00:00
cloudflare-workers-and-pages[bot] commented 2022-12-12 00:25:53 +00:00 (Migrated from github.com)
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4c4c716
Status: ✅  Deploy successful!
Preview URL: https://19937870.organicmaps.pages.dev
Branch Preview URL: https://edit-translations-on-github.organicmaps.pages.dev

View logs

## Deploying with &nbsp;<a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a> &nbsp;Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>4c4c716</code> </td></tr> <tr><td><strong>Status:</strong></td><td>&nbsp;✅&nbsp; Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://19937870.organicmaps.pages.dev'>https://19937870.organicmaps.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://edit-translations-on-github.organicmaps.pages.dev'>https://edit-translations-on-github.organicmaps.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/organicmaps/19937870-fa19-4814-8b84-02d999136d75)
biodranik commented 2022-12-14 10:07:18 +00:00 (Migrated from github.com)
Copy link

@rtsisyk PTAL, let's see if we get more translators via Github.

@rtsisyk PTAL, let's see if we get more translators via Github.
biodranik commented 2022-12-14 10:10:55 +00:00 (Migrated from github.com)
Copy link

We can easily detect the browser's languages and make a list of translations that are NOT present yet on the website. And show the "Translate to..." box only if there are some new languages in the user's browser.

We can easily detect the browser's languages and make a list of translations that are NOT present yet on the website. And show the "Translate to..." box only if there are some new languages in the user's browser.
rtsisyk commented 2022-12-16 09:50:01 +00:00
Owner
Copy link

Can we wait for feedback in https://github.com/organicmaps/organicmaps/discussions/4076 before enforcing any alternative approches? Users will start editing markdowns that are generated (like Indonesian) and it will create total mess.

Can we wait for feedback in https://github.com/organicmaps/organicmaps/discussions/4076 before enforcing any alternative approches? Users will start editing markdowns that are generated (like Indonesian) and it will create total mess.
biodranik commented 2022-12-17 00:58:51 +00:00 (Migrated from github.com)
Copy link
  1. It will be helpful to see what should be changed. After (if) users create PRs, their fixes can be (at the moment) applied to Weblate.
  2. It is possible to disable Edit on GH and leave only Translate To... logic.
1. It will be helpful to see what should be changed. After (if) users create PRs, their fixes can be (at the moment) applied to Weblate. 2. It is possible to disable Edit on GH and leave only Translate To... logic.
rtsisyk commented 2023-02-11 12:36:52 +00:00
Owner
Copy link

Can we add a link to https://hosted.weblate.org/projects/organicmaps/website/ instead?

Can we add a link to https://hosted.weblate.org/projects/organicmaps/website/ instead?
biodranik commented 2023-02-11 22:49:08 +00:00 (Migrated from github.com)
Copy link

@rtsisyk there is no need to show the same link to weblate on each page. It can be placed somewhere in the bottom menu instead, for example.

This PR opens the page that is currently viewed.

@rtsisyk there is no need to show _the same_ link to weblate on each page. It can be placed somewhere in the bottom menu instead, for example. This PR opens the page that is currently viewed.
biodranik commented 2023-02-11 23:20:28 +00:00 (Migrated from github.com)
Copy link

@rtsisyk rebased, PTAL

@rtsisyk rebased, PTAL
biodranik commented 2023-02-18 08:02:30 +00:00 (Migrated from github.com)
Copy link

@rtsisyk а нельзя обновлять po файлы из исправленных markdown? Получается, дорога в weblate - в один конец. И если надо что-то быстро поправить, то сейчас это придётся делать долго, через weblate.

@rtsisyk а нельзя обновлять po файлы из исправленных markdown? Получается, дорога в weblate - в один конец. И если надо что-то быстро поправить, то сейчас это придётся делать долго, через weblate.
rtsisyk commented 2023-02-21 06:22:49 +00:00
Owner
Copy link

@rtsisyk а нельзя обновлять po файлы из исправленных markdown? Получается, дорога в weblate - в один конец. И если надо что-то быстро поправить, то сейчас это придётся делать долго, через weblate.

Искусственный интеллект для обратного запихивания денормализированного текста в нормализированное представление пока еще не изобрели.

> @rtsisyk а нельзя обновлять po файлы из исправленных markdown? Получается, дорога в weblate - в один конец. И если надо что-то быстро поправить, то сейчас это придётся делать долго, через weblate. Искусственный интеллект для обратного запихивания денормализированного текста в нормализированное представление пока еще не изобрели.
biodranik commented 2023-02-21 10:13:51 +00:00 (Migrated from github.com)
Copy link

Искусственный интеллект для обратного запихивания денормализированного текста в нормализированное представление пока еще не изобрели.

@rtsisyk Ты же можешь поправить скрипт, чтобы po файлы обновлялись из маркдаунов?

> Искусственный интеллект для обратного запихивания денормализированного текста в нормализированное представление пока еще не изобрели. @rtsisyk Ты же можешь поправить скрипт, чтобы po файлы обновлялись из маркдаунов?
This pull request has changes conflicting with the target branch.
  • config.toml
  • content/_index.hu.md
  • po/content.hu.po
  • sass/main.scss
  • templates/base.html
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin edit-translations-on-github:edit-translations-on-github
git checkout edit-translations-on-github

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master
git merge --no-ff edit-translations-on-github
git checkout edit-translations-on-github
git rebase master
git checkout master
git merge --ff-only edit-translations-on-github
git checkout edit-translations-on-github
git rebase master
git checkout master
git merge --no-ff edit-translations-on-github
git checkout master
git merge --squash edit-translations-on-github
git checkout master
git merge --ff-only edit-translations-on-github
git checkout master
git merge edit-translations-on-github
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
vng
rtsisyk
Labels
Clear labels   
about page

About Page of the website

  
bug

Something isn't working

  
community page

Community Page of the website

  
documentation

Improvements or additions to documentation

  
donate page

Donate Page of the website

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature page

Feature Page of the website

  
good first issue

Good for newcomers

  
Google Season of Docs

Google Season of Docs

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
landing page

Landing Page of website

  
news page

News Page of the website

  
question

Further information is requested

  
support page

Support Page of the website

  
wontfix

This will not be worked on

No labels
about page
bug
community page
documentation
donate page
duplicate
enhancement
feature page
good first issue
Google Season of Docs
help wanted
invalid
landing page
news page
question
support page
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/website#78
No description provided.
Delete branch "edit-translations-on-github"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?