organicmaps/wikiparser
13
Fork 0
Code Issues13 Pull requests2 Projects Releases Wiki Activity Actions

HTML Processing Fixes #38

Merged
newsch merged 2 commits from processing-fixes into main 2024-04-28 01:12:23 +00:00
Conversation 5 Commits 2 Files changed 1 +71 -26
newsch commented 2024-01-24 20:39:11 +00:00 (Migrated from github.com)
  • Add tests for each case
- [x] Add tests for each case
biodranik (Migrated from github.com) approved these changes 2024-02-22 07:28:51 +00:00
biodranik (Migrated from github.com) left a comment

Thanks! LGTM

Thanks! LGTM
biodranik commented 2024-04-21 12:58:07 +00:00 (Migrated from github.com)

@newsch should these changes be merged?

@newsch should these changes be merged?
newsch commented 2024-04-21 17:01:52 +00:00 (Migrated from github.com)

Not yet, I'm trying to find some sample articles for tests.

Not yet, I'm trying to find some sample articles for tests.
biodranik commented 2024-04-25 19:45:39 +00:00 (Migrated from github.com)

Should it be rebased?

Should it be rebased?
newsch commented 2024-04-28 01:12:13 +00:00 (Migrated from github.com)

From my tests the wrapper div handling was roughly a wash. Some data-heavy articles use them for custom lists and tables which greatly increase the size for little value. I've removed it for now until I can find better heuristics for it.

From my tests the wrapper div handling was roughly a wash. Some data-heavy articles use them for custom lists and tables which greatly increase the size for little value. I've removed it for now until I can find better heuristics for it.
👍 1
biodranik commented 2024-04-28 10:35:39 +00:00 (Migrated from github.com)

Thanks! It's better to avoid storing large chunks of data, most people won't read them anyway from a mobile device on the go.

Thanks! It's better to avoid storing large chunks of data, most people won't read them anyway from a mobile device on the go.
Sign in to join this conversation.
No reviewers
biodranik
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/wikiparser#38
No description provided.
Delete branch "processing-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?