pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] Fix lint warnings for intent-filters (#3595)

Browse source 
* [android] Fix lint warnings for intent-filters

> Data tags should only declare unique attributes
> Consider splitting data tag into multiple tags
> with individual attributes to avoid confusion

All the `<data>` elements contained within the same `<intent-filter>`
element contribute to the same filter. So, for example, the following
filter specification,

```
<intent-filter . . . >
    <data android:scheme="something" android:host="project.example.com" />
    . . .
</intent-filter>
```

is equivalent to this one:

```
<intent-filter . . . >
    <data android:scheme="something" />
    <data android:host="project.example.com" />
    . . .
</intent-filter>
```

https://developer.android.com/guide/topics/manifest/data-element

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>
This commit is contained in:
Roman Tsisyk 2022-10-15 09:16:57 +03:00 • committed by GitHub
parent 6608bafbab
commit 60decd4101
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 58 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

68
android/AndroidManifest.xml
View file

@ -68,7 +68,6 @@
android:name="com.mapswithme.maps.SplashActivity"
android:exported="true">
<!-- standard "geo" scheme -->
<intent-filter>
<action android:name="android.intent.action.VIEW"/>
@ -76,14 +75,6 @@
<category android:name="android.intent.category.BROWSABLE"/>
<data android:scheme="geo"/>
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:scheme="ge0"/>
<data android:scheme="om"/>
</intent-filter>
@ -94,8 +85,9 @@
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:scheme="http" android:host="ge0.me"/>
<data android:scheme="http"/>
<data android:scheme="https"/>
<data android:host="ge0.me"/>
</intent-filter>
<intent-filter android:autoVerify="@bool/autoVerify">
@ -104,8 +96,9 @@
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:scheme="http" android:host="omaps.app"/>
<data android:scheme="http"/>
<data android:scheme="https"/>
<data android:host="omaps.app"/>
</intent-filter>
<intent-filter>
@ -558,24 +551,10 @@
<data android:scheme="https"/>
<!-- #map=$zoom/$lat/$lon -->
<data android:host="www.openstreetmap.org" android:path="/"/>
<data android:host="www.openstreetmap.org" android:pathPrefix="/search"/>
<data android:host="openstreetmap.org" android:path="/"/>
<data android:host="openstreetmap.org" android:pathPrefix="/search"/>
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data
android:host="lead"
android:scheme="mapsme"/>
<data
android:host="lead"
android:scheme="mapswithme"/>
<data android:host="openstreetmap.org"/>
<data android:host="www.openstreetmap.org"/>
<data android:path="/"/>
<data android:path="/search"/>
</intent-filter>
<intent-filter>
@ -602,16 +581,11 @@
<data android:mimeType="application/vnd.google-earth.kmz"/>
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.SEND"/>
<category android:name="android.intent.category.DEFAULT"/>
<data android:mimeType="application/vnd.google-earth.kmz"/>
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.SEND"/>
<category android:name="android.intent.category.DEFAULT"/>
<data android:mimeType="application/vnd.google-earth.kml+xml"/>
<data android:mimeType="application/vnd.google-earth.kmz"/>
</intent-filter>
<intent-filter>
@ -630,35 +604,13 @@
<data android:pathPattern=".*\\..*\\..*\\.kmz" />
<data android:pathPattern=".*\\..*\\..*\\..*\\.kmz" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.kmz" />
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW" />
<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />
<data android:scheme="content"/>
<data android:scheme="file"/>
<data android:scheme="data"/>
<data android:host="*"/>
<data android:mimeType="*/*"/>
<data android:pathPattern="*.kml"/>
<data android:pathPattern=".*\\.kml" />
<data android:pathPattern=".*\\..*\\.kml" />
<data android:pathPattern=".*\\..*\\..*\\.kml" />
<data android:pathPattern=".*\\..*\\..*\\..*\\.kml" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.kml" />
</intent-filter>
<!-- Old MAPS.ME binary format //-->
<intent-filter>
<action android:name="android.intent.action.VIEW"/>
<category android:name="android.intent.category.DEFAULT"/>
<category android:name="android.intent.category.BROWSABLE"/>
<data android:scheme="content"/>
<data android:scheme="file"/>
<data android:scheme="data"/>
<data android:host="*"/>
<data android:mimeType="*/*"/>
<!-- Old MAPS.ME binary format //-->
<data android:pathPattern="*.kmb"/>
<data android:pathPattern=".*\\.kmb" />
<data android:pathPattern=".*\\..*\\.kmb" />