Commit graph

36598 commits

Author SHA1 Message Date
Anton Makouski
32b98975e9
[Routing] Fixes: #2422 + GetTurnDirection() refactoring (#2427)
* [Routing] Fixes: #2422 + refactoring

Currently GetTurnDirection() is overcomplicated.
This is an attempt to make is more straightforward.
Also some bugs were found and fixed.
nodes.candidates was used in many cases
where uturn had to be excluded.
The issue #2422 was expected to be handled even twice:
- Removing a slight turn if ingoing and outgoing edges
are not links and all other possible ways out are links.
- Usage of RightmostDirection() if
the route goes along the rightmost candidate.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>

* [Routing] coding standard

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>

* [Routing] Refactoring

It was checked trough debugging that
there are no significant changes.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>

* [Routing] Refactoring

DiscardTurnByIngoingAndOutgoingEdges() removed as absolete.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>

* [Routing] Refactoring

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>

* [Routing] Refactoring

Added logic for routes which go straight and don't go to a smaller road.

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>

* [Routing] Refactoring

Tests update

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>

* [Routing] Refactoring

Tests update

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>

* [Routing] Refactoring

Comments

Signed-off-by: Anton Makouski <anton.makouski@gmail.com>
2022-04-22 11:46:20 +03:00
Viktor Govako
055bde1fcc Explicitly set ~FileWriter() as noexcept(false).
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-22 11:45:41 +03:00
Alexey
550f13c8f8
Add ru-RU translation for Google play/F-droid (#2414)
* Add ru-RU translation for Google play/F-droid
Signed-off-by: dbf <dbf256@gmail.com>

* Add ru-RU translation for Google play/F-droid
Signed-off-by: dbf <dbf256@gmail.com>

* Add ru-RU translation for Google play/F-droid - fix typo
Signed-off-by: dbf <dbf256@gmail.com>

* Add ru-RU translation for Google play/F-droid - fix metadata
Signed-off-by: dbf <dbf256@gmail.com>

* Add ru-RU translation for Google play/F-droid - code-review fixes
Signed-off-by: dbf <dbf256@gmail.com>

* Add ru-RU translation for Google play/F-droid Apply suggestions from code review
Signed-off-by: dbf <dbf256@gmail.com>
2022-04-21 23:23:15 +02:00
4f75d7b83b [strings] Regenerate
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
2022-04-21 23:22:36 +02:00
a6f7dec659 [strings] Tune amenity=townhall and sightseeings searches
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
2022-04-21 23:22:36 +02:00
6d9ac0bb26 [android] Fix bg color of layers and main menus
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
2022-04-21 22:19:57 +02:00
476b533031 [drape] Add priority mask to DEBUG_OVERLAYS_OUTPUT
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
2022-04-21 23:13:53 +03:00
Viktor Govako
4ca7774992 [test] Relaxed SmallMap benchmark test.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-21 18:09:43 +03:00
Viktor Govako
ebeb81adfd [qt] Refactored RoutingSettings dialog.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-21 18:09:43 +03:00
3dc4c7be4e [storage] Fix updates free space regression
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
2022-04-21 18:09:25 +03:00
Francesco Gazzetta
af8e7878a4 Add Flathub badge to README
Signed-off-by: Francesco Gazzetta <fgaz@fgaz.me>
2022-04-21 14:42:28 +02:00
Viktor Govako
0abd2a28b1 [strings] Regenerated.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-21 08:30:28 +03:00
Viktor Govako
1b5e0e67fa [storage] Removed Storage.m_maxMwmSizeBytes.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-21 08:30:28 +03:00
Viktor Govako
666a1bd5c8 [storage] Fixed IsEnoughSpaceForUpdate.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-21 08:30:28 +03:00
Viktor Govako
aa47daa9a4 [storage] Create version folder before downloading Worlds.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-21 08:30:28 +03:00
021e5da1d4 [cmake] Bump minimum gcc version to 8.1
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
2022-04-20 16:50:19 +02:00
Viktor Govako
864ce2eb41 Updated hierarchy.txt, removed external_resources.txt
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-19 16:18:55 +03:00
Viktor Govako
feeff70bd7 [android] Added World files into countries list.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-19 16:18:55 +03:00
Viktor Govako
752e4c6508 [storage] Minor code prettify and fixes.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-19 16:18:55 +03:00
Viktor Govako
b09d4280f9 [storage] Comment old diff scheme logic until refactoring.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-19 16:18:55 +03:00
Viktor Govako
05a4fcfb5e [storage] Use std::move semantics.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-19 16:18:55 +03:00
Viktor Govako
c7fad20b0f Removed obsolete Framework::m_cityFinder.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-19 16:18:55 +03:00
Viktor Govako
f97d862dd5 Replace std::vector(m2::PointD) code bloat with value initialization.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-19 16:18:55 +03:00
vng
ba2308607d [storage] Do not apply affiliations and synonyms when updating countries.txt
Signed-off-by: vng <viktor.govako@gmail.com>
2022-04-19 16:18:55 +03:00
vng
9fa706ee14 [storage] Fixed countries.txt order lookup.
Signed-off-by: vng <viktor.govako@gmail.com>
2022-04-19 16:18:55 +03:00
Alexander Borsuk
c419288744 Get phone from "mobile" OSM tag
Signed-off-by: Alexander Borsuk <me@alex.bio>
2022-04-19 00:31:07 +02:00
Alexander Borsuk
d2868c34e4 [generator] std::optional for intermediate elements
Signed-off-by: Alexander Borsuk <me@alex.bio>
2022-04-18 21:47:36 +02:00
Alexander Borsuk
0a97d70be4 Fixed unnecessary semicolon warning
Signed-off-by: Alexander Borsuk <me@alex.bio>
2022-04-18 21:47:36 +02:00
Alexander Borsuk
76c3cc9b5f Fixed QtCreator warning
Signed-off-by: Alexander Borsuk <me@alex.bio>
2022-04-18 21:47:36 +02:00
Alexander Borsuk
6fba6e4b0f Minor fixes
Signed-off-by: Alexander Borsuk <me@alex.bio>
2022-04-18 21:47:36 +02:00
Alexander Borsuk
a91a8a06f7 Replaced WARN_UNUSED_RESULT macro with [[nodiscard]] C++11 attribute
Signed-off-by: Alexander Borsuk <me@alex.bio>
2022-04-18 21:47:36 +02:00
Viktor Govako
186c3761c0 [coding] Avoid temporary buffer in MapUint32ToValue.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-17 15:07:00 +03:00
Viktor Govako
e059ac9d73 [drape] Made uint32_t app version code in dump serialization.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-17 15:07:00 +03:00
Viktor Govako
1e7649df8f [qt] Added VisualizeCrossMwmTransitionsInRect.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-17 15:06:40 +03:00
Viktor Govako
c0d7bcef9d [routing] CrossMwmConnector refactoring.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-17 15:06:40 +03:00
Viktor Govako
8b8bcfe610 [routing] Added CrossMwmConnector::ForEachTransitSegmentId instead of raw getters.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-17 15:06:40 +03:00
Viktor Govako
559e8d40c6 [qt] Better selection toolbar layout.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-17 15:06:40 +03:00
Viktor Govako
8dded8ef00 [drape] Log visual scale and tile size.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-17 15:06:40 +03:00
Francesco Gazzetta
14eb87bba7 [desktop] Use XDG path for settings
Signed-off-by: Francesco Gazzetta <fgaz@fgaz.me>
2022-04-17 12:54:37 +02:00
Viktor Govako
2eb10e2583 [platform] Fixed bug with temporary string in platform::GetFilePathByUrl.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-17 11:22:14 +03:00
Anton Makouski
9f1bce4564
Merge pull request #2397 from AntonM030481/navigation-turn-directions
[routing] Remove unnecessary "keep left/right" directions from the route

Signed-off-by: Anton Makouski anton.makouski@gmail.com
2022-04-15 22:11:41 +03:00
Francesco Gazzetta
0808dbe82b [desktop] update logo
again copying the one from android

Signed-off-by: Francesco Gazzetta <fgaz@fgaz.me>
2022-04-15 19:47:40 +02:00
Francesco Gazzetta
14fabe1a2c [ci][desktop] add appstream check
Signed-off-by: Francesco Gazzetta <fgaz@fgaz.me>
2022-04-15 19:47:40 +02:00
Francesco Gazzetta
395b1b1151 [desktop] make appstream data pass validation
Signed-off-by: Francesco Gazzetta <fgaz@fgaz.me>
2022-04-15 19:47:40 +02:00
Alexander Borsuk
6e0a3c70e9 Minor warning fixes
Signed-off-by: Alexander Borsuk <me@alex.bio>
2022-04-15 19:42:44 +02:00
Viktor Govako
e8a8f8a515 [tests] Print unexpected exception.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-15 09:29:07 +03:00
Viktor Govako
d8cbbe5630 [generator] Added IsWayWithDurationChecker to store "duration" tag not only for ferries.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-15 09:29:07 +03:00
Viktor Govako
c0a2c3c06c [routing] Relax no-pass-through-allowed criteria.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-15 09:29:07 +03:00
Viktor Govako
9f6b6886c9 [desktop] Show descriptions size in PP.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-15 09:29:07 +03:00
Viktor Govako
2c5ce7aaf7 [iOS][android][editor] Fixed auth warnings.
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
2022-04-15 09:29:07 +03:00