When the user deletes the file locally with the enabled icloud happens this:
1. the file is moved to the local .Trash dir
2. the LocalDirectoryMonitor send event to delete the file from the iCloud
3. the SynchronizationFileWriter trash the remote file using the system API `try fileManager.trashItem`
4. the file is moved to the devices trash
5. the icloud sends the update to the metadataQery's `queryDidUpdate` with the updated state. This update is tricky - it calls the method twice: on the first call the deleted file appears in the updated list (`userInfo[NSMetadataQueryUpdateChangedItemsKey]`) and on the second call the deleted file appears in the deleted list (`userInfo[NSMetadataQueryUpdateRemovedItemsKey]`). There is no way to disable this behaviour.
At that point the bug can happens: the 1st `update` (that contains the file in the deleted list) call can triggers the file recreation because the synchroisztion starts to process the event and make an attempt to recreate the file but it is already deleted.
The fix is: skip missed file during the `Update` event. The case when the missed file is in the updated in undefined and should be skipped by checking the file existence.
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
It's a legit case when a listener is removed from the list as a result of call to that listener. That causes the list of listeners to be modified during an iteration, which is not supported by standart collections.
The most efficient option to support that is to use ObserverList from Chromium project and this is done here.
Another options are a) to use CopyOnWriteArrayList b) to use Listeners class from the codebase. Both of them are less efficient and do more allocations.
Resolves#546
Signed-off-by: Alexey Krasilnikov <alexey@krasilnikov.me>
1. for now the structure is SheetStyle.Global/PlacePage/Font/TestColor...
2. the styles are used by assessing the property
before:
lineView.setStyleAndApply("Divider")
headerTitleLabel.setStyleAndApply("semibold18:blackPrimaryText")
after:
lineView.setStyleAndApply(.global(.divider))
headerTitleLabel.setFontStyle(.semibold18, color: .blackPrimary)
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
1. Restore the original simple version of `configure.sh`
Restores 08e37f4 "Refactor configure.sh"
Reverts b87ee95b "Fixed configure.sh script and gh actions"
2. Use GitHub Secrets instead of a private git repository to enhance
security standards and ensure credentials are encrypted and safely
managed.
3. Document credentials used by GitHub Actions in docs/CREDENTIALS.md
4. Include `network_security_config.xml` directly into the repo
as it has nothing sensitive.
5. Include Apple WWDR intermediate certificates directly into the repo
as they are not sensitive and publicly available.
https://developer.apple.com/help/account/reference/wwdr-intermediate-certificates
6. Add `private.h` in the repository since it does not differ from
`private_defaults.h`.
Signed-off-by: Roman Tsisyk <roman@tsisyk.com>
