[android] Add bottom sheet (modal) search screen #10462

Open

savsch wants to merge 2 commits from savsch/feat/android-modal-search into master

savsch commented

2025-03-10 10:49:02 +00:00

(Migrated from github.com)

Resolves #10206
Makes some progress on #5675

This PR implements the search screen as a bottom sheet. For tablet layout (which is currently disabled even for tablets in the code), the UI (side panel) remains unchanged.

The bottom sheet has four modes:
- expanded
- half expanded (only for portrait mode) (default)
- collapsed (skipped when the search query is empty)
- hidden 😶
The search UI remains hidden for as long as place-page is active.
The search is always interactive (results are shown on the map)
The bottom sheet can be dragged between different states through the top area (drag handle and search toolbar)

TODO

Fix the bug where the search results or categories erratically become unscrollable unless the search is closed and reopened.
Migrate SearchActivity's only remaining utility (opening search uri intents) to modal search (or, in case of tablet layout, to the existing fragment panel in MwmActivity)
Collapse search screen when map is touched (or dismiss it entirely if the search query is empty)
Maybe increase the height for when the bottom sheet is in the collapsed state
Retain search results on configuration changes
Check that the existing tablet layout still works (currently disabled in the code, unrelated to this PR)
Test on more screen sizes
Add comments

Screenshots

https://github.com/user-attachments/assets/cd7a0fd2-a3ab-4660-9140-66a89d1546c0

Footnote

The PR was originally supposedly inspired by #10213, although I have strayed a lot from it during the implementation (need feedback).

Resolves #10206 Makes some progress on #5675 This PR implements the search screen as a bottom sheet. For tablet layout (which is currently disabled even for tablets in the code), the UI (side panel) remains unchanged. - The bottom sheet has four modes: - expanded - half expanded (only for portrait mode) (default) - collapsed (skipped when the search query is empty) - hidden 😶 - The search UI remains hidden for as long as place-page is active. - The search is always interactive (results are shown on the map) - The bottom sheet can be dragged between different states through the top area (drag handle and search toolbar) ### TODO - [x] Fix the bug where the search results or categories erratically become unscrollable unless the search is closed and reopened. - [x] Migrate SearchActivity's only remaining utility (opening search uri intents) to modal search (or, in case of tablet layout, to the existing fragment panel in MwmActivity) - [ ] Collapse search screen when map is touched (or dismiss it entirely if the search query is empty) - [ ] Maybe increase the height for when the bottom sheet is in the collapsed state - [x] Retain search results on configuration changes - [ ] Check that the existing tablet layout still works (currently disabled in the code, unrelated to this PR) - [x] Test on more screen sizes - [ ] Add comments ### Screenshots ![Screenshot_1741603181](https://github.com/user-attachments/assets/01f49b50-1467-482a-a6fe-1b5fd2a1c3e6) https://github.com/user-attachments/assets/cd7a0fd2-a3ab-4660-9140-66a89d1546c0 ![Screenshot_1741717164](https://github.com/user-attachments/assets/6346f905-ac5c-40c7-a0a4-3d1536875b3e) ![Screenshot_1741717149](https://github.com/user-attachments/assets/f126f351-febb-4f8f-960f-44911bb8bc64) ![Screenshot_1741717124](https://github.com/user-attachments/assets/9bddd321-ddbf-4f78-ae34-8fd23e4f4e54) ### Footnote The PR was originally supposedly inspired by #10213, although I have strayed a lot from it during the implementation (need feedback).

🚀 5

RedAuburn reviewed 2025-03-11 18:38:02 +00:00

android/app/src/main/java/app/organicmaps/sdk/search/SearchResult.java

RedAuburn commented

2025-03-11 18:38:02 +00:00

Member

why? is it deprecated now?

savsch (Migrated from github.com) reviewed 2025-03-11 19:10:02 +00:00

android/app/src/main/java/app/organicmaps/sdk/search/SearchResult.java

savsch (Migrated from github.com) commented

2025-03-11 19:10:02 +00:00

Thanks for the feedback. Isn't it standard (and required) practice to implement describeContents in parcelable classes (and return 0 unless it has something to do with serializing file descriptors)?

Thanks for the feedback. Isn't it standard (and required) practice to implement `describeContents` in parcelable classes (and `return 0` unless it has something to do with serializing file descriptors)?