organicmaps/organicmaps-tmp
Archived
13
Fork 1
Code Issues 2.7k Pull requests 182 Projects Releases 65 Wiki Activity Actions

[Android] OAuth2 flow with browser #8825

Closed
strump wants to merge 13 commits from android-oauth2-with-browser into master
pull from: android-oauth2-with-browser
merge into: organicmaps:master
Conversation 0 Commits 13 Files changed 25 +596 -233
strump commented 2024-08-02 13:24:13 +00:00
Member
Copy link

How new flow should work (happy path):

  1. OsmLoginFragment - User pushes "Login with OSM website" button
  2. OsmLoginFragment - triggers browser
  3. Browser - OSM.org login flow
  4. Browser - redirects to om://oauth2/osm/callback?code=XXX
  5. MwmActivity - handles om:// URI and extracts code value
  6. MwmActivity - calls OsmLoginActivity with code in extras
  7. OsmLoginFragment - calls native code to get OAuth2 token using code
  8. OsmLoginFragment - calls native code to get username using OAuth2 token
  9. OsmLoginFragment - redirects to ProfileActivity

https://github.com/user-attachments/assets/17fd44c3-a3b5-4a5f-adf4-05da30c10c66

Question: What about UI? How we can handle two types of logging in: OAuth2 via browser, and login+password?

Update 2024-09-19

Changed OSM Login UI to have popup bottom panel:

https://github.com/user-attachments/assets/4757b358-e99a-4052-a2bd-6363ae784a87

Update 2024-09-20

Added round corners:

How new flow should work (happy path): 1. `OsmLoginFragment` - User pushes "Login with OSM website" button 2. `OsmLoginFragment` - triggers browser 3. `Browser` - OSM.org login flow 4. `Browser` - redirects to om://oauth2/osm/callback?code=XXX 5. `MwmActivity` - handles `om://` URI and extracts `code` value 6. `MwmActivity` - calls OsmLoginActivity with `code` in extras 7. `OsmLoginFragment` - calls native code to get OAuth2 token using `code` 8. `OsmLoginFragment` - calls native code to get username using OAuth2 token 9. `OsmLoginFragment` - redirects to `ProfileActivity` https://github.com/user-attachments/assets/17fd44c3-a3b5-4a5f-adf4-05da30c10c66 **Question:** What about UI? How we can handle two types of logging in: OAuth2 via browser, and login+password? ### Update 2024-09-19 Changed OSM Login UI to have popup bottom panel: https://github.com/user-attachments/assets/4757b358-e99a-4052-a2bd-6363ae784a87 ### Update 2024-09-20 Added round corners: <img src="https://github.com/user-attachments/assets/db46574e-2edc-4ab3-8c63-4f698eab63f9" width="400px"/>
👍 1
rtsisyk reviewed 2024-08-02 13:24:13 +00:00
strump reviewed 2024-08-02 15:25:08 +00:00
android/app/src/main/res/layout/fragment_osm_login.xml
strump commented 2024-08-02 13:29:54 +00:00
Author
Member

TODO: introduce new string "Login with OSM website" instead of hardcoded one

TODO: introduce new string "Login with OSM website" instead of hardcoded one
Jean-BaptisteC (Migrated from github.com) approved these changes 2024-08-04 16:47:58 +00:00
Jean-BaptisteC (Migrated from github.com) left a comment

✅ Pixel 6 - Android 14
FYI, when i press one button 2 buttons change her background color.

✅ Pixel 6 - Android 14 FYI, when i press one button 2 buttons change her background color.
biodranik (Migrated from github.com) reviewed 2024-08-19 10:54:00 +00:00
android/app/src/main/res/layout/fragment_osm_login.xml
biodranik (Migrated from github.com) commented 2024-08-19 10:54:00 +00:00

If website login works only for Google Play builds, then there's no need to translate anything or add a second button.

If website login works only for Google Play builds, then there's no need to translate anything or add a second button.
biodranik (Migrated from github.com) reviewed 2024-08-19 11:13:37 +00:00
biodranik (Migrated from github.com) left a comment

Thanks!

I got a crash on Android 15 emulator when clicking OSM login profile using this PR rebased on the latest master:

2024-08-19 13:12:12.076  3588-3588  AndroidRuntime          app.organicmaps.debug                E  FATAL EXCEPTION: main
                                                                                                    Process: app.organicmaps.debug, PID: 3588
                                                                                                    java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.Button.setOnClickListener(android.view.View$OnClickListener)' on a null object reference
                                                                                                    	at app.organicmaps.editor.OsmLoginFragment.onViewCreated(OsmLoginFragment.java:56)
                                                                                                    	at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3152)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:608)
                                                                                                    	at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:286)
                                                                                                    	at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:114)
                                                                                                    	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1675)
                                                                                                    	at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3259)
                                                                                                    	at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:3177)
                                                                                                    	at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:263)
                                                                                                    	at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:350)
                                                                                                    	at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:251)
                                                                                                    	at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1701)
                                                                                                    	at android.app.Activity.performStart(Activity.java:9045)
                                                                                                    	at android.app.ActivityThread.handleStartActivity(ActivityThread.java:4073)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:270)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:250)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:222)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:107)
                                                                                                    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:81)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2636)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:107)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:232)
                                                                                                    	at android.os.Looper.loop(Looper.java:317)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:8705)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886)
Thanks! I got a crash on Android 15 emulator when clicking OSM login profile using this PR rebased on the latest master: ``` 2024-08-19 13:12:12.076 3588-3588 AndroidRuntime app.organicmaps.debug E FATAL EXCEPTION: main Process: app.organicmaps.debug, PID: 3588 java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.Button.setOnClickListener(android.view.View$OnClickListener)' on a null object reference at app.organicmaps.editor.OsmLoginFragment.onViewCreated(OsmLoginFragment.java:56) at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3152) at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:608) at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:286) at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:114) at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1675) at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3259) at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:3177) at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:263) at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:350) at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:251) at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1701) at android.app.Activity.performStart(Activity.java:9045) at android.app.ActivityThread.handleStartActivity(ActivityThread.java:4073) at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:270) at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:250) at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:222) at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:107) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:81) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2636) at android.os.Handler.dispatchMessage(Handler.java:107) at android.os.Looper.loopOnce(Looper.java:232) at android.os.Looper.loop(Looper.java:317) at android.app.ActivityThread.main(ActivityThread.java:8705) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886) ```
android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
biodranik (Migrated from github.com) commented 2024-08-19 10:56:35 +00:00 
    auto const auth = OsmOAuth::ServerAuth();
```suggestion auto const auth = OsmOAuth::ServerAuth(); ```
biodranik (Migrated from github.com) commented 2024-08-19 10:57:54 +00:00 
Java_app_organicmaps_editor_OsmOAuth_nativeOAuthParams(JNIEnv * env, jclass)
```suggestion Java_app_organicmaps_editor_OsmOAuth_nativeOAuthParams(JNIEnv * env, jclass) ```
android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
@ -55,0 +62,4 @@
JNIEXPORT jstring JNICALL
Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass, jstring oauth2code)
{
OsmOAuth auth = OsmOAuth::ServerAuth();
biodranik (Migrated from github.com) commented 2024-08-19 10:59:50 +00:00 
Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass, jstring oauth2code)
```suggestion Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass, jstring oauth2code) ```
biodranik (Migrated from github.com) commented 2024-08-19 11:00:42 +00:00 
    LOG(LWARNING, ("nativeAuthWithOAuth2Code: invalid OAuth2 code", oauth2code));
```suggestion LOG(LWARNING, ("nativeAuthWithOAuth2Code: invalid OAuth2 code", oauth2code)); ```
android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@ -87,0 +91,4 @@
final String oauthToken = OsmOAuth.nativeAuthWithOAuth2Code(oauth2code);
final String username = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
UiThread.run(() -> {
processAuth(oauthToken, username);
biodranik (Migrated from github.com) commented 2024-08-19 11:03:18 +00:00

If om://oauth2 scheme is parsed in C++, does it make sense to make the initial URI also on the C++ side? Will it allow reusing of a similar login approach for iOS?

If om://oauth2 scheme is parsed in C++, does it make sense to make the initial URI also on the C++ side? Will it allow reusing of a similar login approach for iOS?
biodranik (Migrated from github.com) commented 2024-08-19 11:03:30 +00:00 
    try
    {
```suggestion try { ```
biodranik (Migrated from github.com) commented 2024-08-19 11:03:44 +00:00 
    }
    catch (ActivityNotFoundException e)
    {
```suggestion } catch (ActivityNotFoundException e) { ```
biodranik (Migrated from github.com) commented 2024-08-19 11:04:32 +00:00

Showing a toast in hard-coded English here is a good idea. And also logging this as a warning.

Showing a toast in hard-coded English here is a good idea. And also logging this as a warning.
biodranik (Migrated from github.com) commented 2024-08-19 11:04:51 +00:00

enableInput(true); ?

`enableInput(true);` ?
biodranik (Migrated from github.com) commented 2024-08-19 11:05:39 +00:00

It would be great to reuse the same login button (GP flavor uses web login, other flavors use password)

It would be great to reuse the same login button (GP flavor uses web login, other flavors use password)
biodranik (Migrated from github.com) commented 2024-08-19 11:05:57 +00:00 
    if (oauth2code == null || oauth2code.length() == 0)
```suggestion if (oauth2code == null || oauth2code.length() == 0) ```
biodranik (Migrated from github.com) commented 2024-08-19 11:07:01 +00:00

It is called in processAuth below (but after an if)

It is called in processAuth below (but after an if)
android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
biodranik (Migrated from github.com) commented 2024-08-19 11:06:18 +00:00 
      ThreadPool.getWorker().execute(() -> 
      {
```suggestion ThreadPool.getWorker().execute(() -> { ```
android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
biodranik (Migrated from github.com) commented 2024-08-19 11:08:54 +00:00

Passing null value for a username will later remove it from preferences.

Passing null value for a username will later remove it from preferences.
android/app/src/main/java/app/organicmaps/intent/Factory.java
biodranik (Migrated from github.com) commented 2024-08-19 11:09:45 +00:00

Why the search should be canceled?

Why the search should be canceled?
map/mwm_url.hpp
biodranik (Migrated from github.com) commented 2024-08-19 11:11:59 +00:00 
    ASSERT_EQUAL(m_requestType, UrlType::OAuth2, ("Expected OAuth2 API"));
```suggestion ASSERT_EQUAL(m_requestType, UrlType::OAuth2, ("Expected OAuth2 API")); ```
strump reviewed 2024-08-19 14:27:06 +00:00
map/mwm_url.hpp
strump commented 2024-08-19 14:27:06 +00:00
Author
Member

Fixed

Fixed
strump reviewed 2024-08-19 14:27:34 +00:00
android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@ -87,0 +91,4 @@
final String oauthToken = OsmOAuth.nativeAuthWithOAuth2Code(oauth2code);
final String username = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
UiThread.run(() -> {
processAuth(oauthToken, username);
strump commented 2024-08-19 14:27:34 +00:00
Author
Member

You are right. I modified to build OAuth2 URL using native code instead of Java.

You are right. I modified to build OAuth2 URL using native code instead of Java.
strump reviewed 2024-08-19 14:27:41 +00:00
android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
@ -55,0 +62,4 @@
JNIEXPORT jstring JNICALL
Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass, jstring oauth2code)
{
OsmOAuth auth = OsmOAuth::ServerAuth();
strump commented 2024-08-19 14:27:41 +00:00
Author
Member

Fixed

Fixed
strump reviewed 2024-08-19 14:27:44 +00:00
android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
@ -55,0 +62,4 @@
JNIEXPORT jstring JNICALL
Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass, jstring oauth2code)
{
OsmOAuth auth = OsmOAuth::ServerAuth();
strump commented 2024-08-19 14:27:44 +00:00
Author
Member

Fixed

Fixed
strump reviewed 2024-08-19 14:27:48 +00:00
android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
strump commented 2024-08-19 14:27:48 +00:00
Author
Member

Fixed

Fixed
strump reviewed 2024-08-19 14:27:52 +00:00
android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
strump commented 2024-08-19 14:27:52 +00:00
Author
Member

Fixed

Fixed
strump reviewed 2024-08-19 14:28:44 +00:00
android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@ -87,0 +91,4 @@
final String oauthToken = OsmOAuth.nativeAuthWithOAuth2Code(oauth2code);
final String username = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
UiThread.run(() -> {
processAuth(oauthToken, username);
strump commented 2024-08-19 14:28:43 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2024-08-19 14:28:50 +00:00
android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@ -87,0 +91,4 @@
final String oauthToken = OsmOAuth.nativeAuthWithOAuth2Code(oauth2code);
final String username = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
UiThread.run(() -> {
processAuth(oauthToken, username);
strump commented 2024-08-19 14:28:50 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2024-08-19 14:29:09 +00:00
android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@ -87,0 +91,4 @@
final String oauthToken = OsmOAuth.nativeAuthWithOAuth2Code(oauth2code);
final String username = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
UiThread.run(() -> {
processAuth(oauthToken, username);
strump commented 2024-08-19 14:29:09 +00:00
Author
Member

Changed to .isEmpty()

Changed to `.isEmpty()`
Jean-BaptisteC (Migrated from github.com) requested changes 2024-08-19 15:09:40 +00:00
Jean-BaptisteC (Migrated from github.com) left a comment

❌ Pixel 6 - Android 14
Rotate device on login fragment -> crash
IMO, it's better to keep button to create an account outside of bottomsheet

❌ Pixel 6 - Android 14 Rotate device on login fragment -> crash IMO, it's better to keep button to create an account outside of bottomsheet
biodranik (Migrated from github.com) reviewed 2024-08-19 18:12:58 +00:00
biodranik (Migrated from github.com) left a comment

Thanks! Some nits and unfixed comments from last time.

Thanks! Some nits and unfixed comments from last time.
android/app/src/main/cpp/app/organicmaps/Framework.cpp
biodranik (Migrated from github.com) commented 2024-08-19 18:06:56 +00:00 
  std::string const & code = frm()->GetParsedOAuth2Code();
  return jni::ToJavaString(env, code);
```suggestion std::string const & code = frm()->GetParsedOAuth2Code(); return jni::ToJavaString(env, code); ```
android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
biodranik (Migrated from github.com) commented 2024-08-19 18:07:06 +00:00 
  auto const auth = OsmOAuth::ServerAuth();
  return ToJavaString(env, auth.BuildOAuth2Url());
```suggestion auto const auth = OsmOAuth::ServerAuth(); return ToJavaString(env, auth.BuildOAuth2Url()); ```
android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
biodranik (Migrated from github.com) commented 2024-08-19 18:08:02 +00:00 
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik (Migrated from github.com) commented 2024-08-19 18:08:22 +00:00

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik (Migrated from github.com) commented 2024-08-19 18:09:08 +00:00

Why the text is cleared?

Why the text is cleared?
android/app/src/main/res/layout/fragment_osm_login_bottom.xml
biodranik (Migrated from github.com) commented 2024-08-19 18:10:12 +00:00

?

?
biodranik (Migrated from github.com) commented 2024-08-19 18:10:32 +00:00

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
editor/osm_auth.cpp
biodranik (Migrated from github.com) commented 2024-08-19 18:11:44 +00:00 
   return requestTokenUrl.append('?').append(requestTokenQuery);

Please use std::string everywhere.

```suggestion return requestTokenUrl.append('?').append(requestTokenQuery); ``` Please use std::string everywhere.
strump reviewed 2024-08-20 06:37:17 +00:00
android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
strump commented 2024-08-20 06:37:17 +00:00
Author
Member

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
strump reviewed 2024-08-20 07:17:46 +00:00
android/app/src/main/res/layout/fragment_osm_login_bottom.xml
strump commented 2024-08-20 07:17:46 +00:00
Author
Member

Fixed formatting

Fixed formatting
strump reviewed 2024-08-20 07:17:52 +00:00
android/app/src/main/res/layout/fragment_osm_login_bottom.xml
strump commented 2024-08-20 07:17:52 +00:00
Author
Member

Fixed XML formatting

Fixed XML formatting
strump reviewed 2024-08-20 07:18:08 +00:00
android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
strump commented 2024-08-20 07:18:08 +00:00
Author
Member

Reformatted this class

Reformatted this class
strump reviewed 2024-08-20 07:23:51 +00:00
android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@ -87,0 +91,4 @@
final String oauthToken = OsmOAuth.nativeAuthWithOAuth2Code(oauth2code);
final String username = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
UiThread.run(() -> {
processAuth(oauthToken, username);
strump commented 2024-08-20 07:23:51 +00:00
Author
Member

I replaced this code with Utils.openUri(...). It handles missing browser error.

I replaced this code with `Utils.openUri(...)`. It handles missing browser error.
strump reviewed 2024-08-20 07:26:33 +00:00
android/app/src/main/java/app/organicmaps/intent/Factory.java
strump commented 2024-08-20 07:26:33 +00:00
Author
Member

I don't know if it makes sense. I copied this line from previous case blocks.

Shoul be removed?

I don't know if it makes sense. I copied this line from previous `case` blocks. Shoul be removed?
biodranik (Migrated from github.com) requested changes 2024-08-21 09:53:54 +00:00
biodranik (Migrated from github.com) left a comment

Thanks!

@strump this is a bad UX:

  • two login buttons (which one should a grandpa choose?)
  • No Register button for new users
  • No forget password for existing users

Note that web browser login won't work smoothly on many custom/ungoogled firmware, it has been reported by other developers doing a similar web-based OSM auth.

As we really need a web login for the Google Play version only, let's leave an old UI for other flavors, and show only a web login button for Google Play version.

выява

Thanks! @strump this is a bad UX: - two login buttons (which one should a grandpa choose?) - No Register button for new users - No forget password for existing users Note that web browser login won't work smoothly on many custom/ungoogled firmware, it has been reported by other developers doing a similar web-based OSM auth. As we really need a web login _for the Google Play version only_, let's leave an old UI for other flavors, and show only a web login button for Google Play version. ![выява](https://github.com/user-attachments/assets/f4b84bc8-7fa7-4e0d-a01b-43ff69ea78a1)
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
rtsisyk
Jean-BaptisteC
biodranik
Labels
Clear labels   
Accessibility

issues affecting users with specific needs

  
Accessibility

issues affecting users with specific needs

  
Address

Issues with addresses, post codes, city/town/village borders

  
Address

Issues with addresses, post codes, city/town/village borders

  
Android

Android development

  
Android

Android development

  
Android Auto

Android Auto

  
Android Auto

Android Auto

  
Android Automotive (AAOS)

   
Android Automotive (AAOS)

   
API

Short Links, deep links and url schemes, including ge0 and om://

  
API

Short Links, deep links and url schemes, including ge0 and om://

  
AppGallery

Huawei AppGallery

  
AppGallery

Huawei AppGallery

  
AppStore

Apple AppStore

  
AppStore

Apple AppStore

  
Battery and Performance

Performance and battery consumption-related issues and optimizations

  
Battery and Performance

Performance and battery consumption-related issues and optimizations

  
Blocker

An issue blocking the release

  
Blocker

An issue blocking the release

  
Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  
Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  
Borders

Country borders and polygons

  
Borders

Country borders and polygons

  
Bug

Something isn't working

  
Bug

Something isn't working

  
Build

Compilation issue

  
Build

Compilation issue

  
CarPlay

CarPlay Integration

  
CarPlay

CarPlay Integration

  
Classificator

Classify object by types

  
Classificator

Classify object by types

  
Community

Community relations

  
Community

Community relations

  
Core

Cross-platform C++ libraries with a core functionality

  
Core

Cross-platform C++ libraries with a core functionality

  
CrashReports

Crash Reporting

  
CrashReports

Crash Reporting

  
Cycling

Bike, cycle, biking and related

  
Cycling

Bike, cycle, biking and related

  
Desktop

Desktop application

  
Desktop

Desktop application

  
DevEx

Developer Experience

  
DevEx

Developer Experience

  
DevOps

Automation and pipelines

  
DevOps

Automation and pipelines

  
dev_sandbox

A desktop app to debug rendering

  
dev_sandbox

A desktop app to debug rendering

  
Directions

Issues with next turns, labels, streets, voice instructions

  
Directions

Issues with next turns, labels, streets, voice instructions

  
Documentation

Improvements or additions to documentation

  
Documentation

Improvements or additions to documentation

  
Downloader

Map dowloader

  
Downloader

Map dowloader

  
Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  
Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  
Driving

Drive a car related issues

  
Driving

Drive a car related issues

  
Duplicate

This issue or pull request already exists

  
Duplicate

This issue or pull request already exists

  
Editor

OSM Editor

  
Editor

OSM Editor

  
Elevation

Isolines and altitude

  
Elevation

Isolines and altitude

  
Enhancement

New feature or request, an improvement of some existing feature

  
Enhancement

New feature or request, an improvement of some existing feature

  
Epic

A large body work

  
Epic

A large body work

  
External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  
External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  
F-Droid

F-Droid build and distribution

  
F-Droid

F-Droid build and distribution

  
Fonts

Font and text rendering

  
Fonts

Font and text rendering

  
Frequently User Reported

Most annoying UX and other issues for users reported by many people

  
Frequently User Reported

Most annoying UX and other issues for users reported by many people

  
Fund

   
Fund

   
Generator

Related to generator tool.

  
Generator

Related to generator tool.

  
Good first issue

Good for newcomers

  
Good first issue

Good for newcomers

  
Google Play

Google Play

  
Google Play

Google Play

  
GPS

Location and positioning issues

  
GPS

Location and positioning issues

  
GSoC

Ideas for Google Summer of Code

  
GSoC

Ideas for Google Summer of Code

  
iCloud

   
iCloud

   
Icons

Map and app icons

  
Icons

Map and app icons

  
iOS

iOS development

  
iOS

iOS development

  
Legal

Legal aspects

  
Legal

Legal aspects

  
Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  
Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  
Linux packaging

   
Linux packaging

   
Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  
Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  
Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  
Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  
Map Data

OpenStreetMap data related issues

  
Map Data

OpenStreetMap data related issues

  
Metro

Subway, Tube, light-rail public transport issues

  
Metro

Subway, Tube, light-rail public transport issues

  
Navigation

Issues related to the active Navigator / Navigation mode

  
Navigation

Issues related to the active Navigator / Navigation mode

  
Need Feedback

Further information is requested

  
Need Feedback

Further information is requested

  
Night Mode

Night or dark mode feature

  
Night Mode

Night or dark mode feature

  
NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  
NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  
No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  
No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  
Opening Hours

Business Hours, off time, holidays, seasonal

  
Opening Hours

Business Hours, off time, holidays, seasonal

  
Outdoors

Hiking, mtb, 4x4...

  
Outdoors

Hiking, mtb, 4x4...

  
POI Info

Feature metadata, OSM tags that are displayed in Place Page

  
POI Info

Feature metadata, OSM tags that are displayed in Place Page

  
Privacy

Privacy

  
Privacy

Privacy

  
Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  
Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  
Raw Idea

An idea that needs to be elaborated

  
Raw Idea

An idea that needs to be elaborated

  
Refactoring

   
Refactoring

   
Regional

This issue is different depending on the country or region

  
Regional

This issue is different depending on the country or region

  
Regression

A regression bug

  
Regression

A regression bug

  
Releases

Meta-tickets for tracking the release procedure

  
Releases

Meta-tickets for tracking the release procedure

  
RoboTest

Robo / Monkey Auto Tests

  
RoboTest

Robo / Monkey Auto Tests

  
Route Planning

Preview and plan your track

  
Route Planning

Preview and plan your track

  
Routing

Route building issues, e.g. valid route, valid ETA

  
Routing

Route building issues, e.g. valid route, valid ETA

  
Ruler

Helicopter routing, "as a crow flies"

  
Ruler

Helicopter routing, "as a crow flies"

  
Search

Search

  
Search

Search

  
Security

Security improvements

  
Security

Security improvements

  
Styles

Map drawing styles

  
Styles

Map drawing styles

  
Tests

   
Tests

   
Track Recording

Track Recording

  
Track Recording

Track Recording

  
Translations

Localization and translations issues

  
Translations

Localization and translations issues

  
TTS

Text-to-Speech

  
TTS

Text-to-Speech

  
UI

User interface issues

  
UI

User interface issues

  
UX

User eXperience, an issue with usability

  
UX

User eXperience, an issue with usability

  
Walk Navigation

Foot pedestrian mode

  
Walk Navigation

Foot pedestrian mode

  
Watches

Android Watches or Apple Watches support

  
Watches

Android Watches or Apple Watches support

  
Web

https://organicmaps.app/

  
Web

https://organicmaps.app/

  
Wikipedia

Issues related to Wiki articles embedded in OM data files.

  
Wikipedia

Issues related to Wiki articles embedded in OM data files.

  
Windows

Windows

  
Windows

Windows

  
Won't fix

Unfeasible or impossible to resolve

  
Won't fix

Unfeasible or impossible to resolve

  
World Map

Issues about improving the base map of the whole world that is bundled with the app

  
World Map

Issues about improving the base map of the whole world that is bundled with the app

No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#8825
No description provided.
Delete branch "android-oauth2-with-browser"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?