[Android] OAuth2 flow with browser #8825

Closed
strump wants to merge 13 commits from android-oauth2-with-browser into master
25 changed files with 596 additions and 233 deletions

View file

@ -862,6 +862,13 @@ Java_app_organicmaps_Framework_nativeGetParsedAppName(JNIEnv * env, jclass)
return (appName.empty()) ? nullptr : jni::ToJavaString(env, appName);
}
JNIEXPORT jstring JNICALL
Java_app_organicmaps_Framework_nativeGetParsedOAuth2Code(JNIEnv * env, jclass)
{
std::string const & code = frm()->GetParsedOAuth2Code();
return jni::ToJavaString(env, code);
}
JNIEXPORT jstring JNICALL
Java_app_organicmaps_Framework_nativeGetParsedBackUrl(JNIEnv * env, jclass)
{

View file

@ -34,6 +34,13 @@ bool LoadOsmUserPreferences(std::string const & oauthToken, UserPreferences & ou
extern "C"
{
JNIEXPORT jstring JNICALL
Java_app_organicmaps_editor_OsmOAuth_nativeGetOAuth2Url(JNIEnv * env, jclass)
{
auto const auth = OsmOAuth::ServerAuth();
return ToJavaString(env, auth.BuildOAuth2Url());
}
JNIEXPORT jstring JNICALL
Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithPassword(JNIEnv * env, jclass clazz,
jstring login, jstring password)
@ -52,6 +59,27 @@ Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithPassword(JNIEnv * env, jclass
return nullptr;
}
JNIEXPORT jstring JNICALL
Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass, jstring oauth2code)
{
OsmOAuth auth = OsmOAuth::ServerAuth();
biodranik commented 2024-08-19 10:59:50 +00:00 (Migrated from github.com)
Review
Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass, jstring oauth2code)
```suggestion Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass, jstring oauth2code) ```
biodranik commented 2024-08-19 11:00:42 +00:00 (Migrated from github.com)
Review
    LOG(LWARNING, ("nativeAuthWithOAuth2Code: invalid OAuth2 code", oauth2code));
```suggestion LOG(LWARNING, ("nativeAuthWithOAuth2Code: invalid OAuth2 code", oauth2code)); ```
Review

Fixed

Fixed
Review

Fixed

Fixed
try
{
auto token = auth.FinishAuthorization(ToNativeString(env, oauth2code));
if (!token.empty())
{
auth.SetAuthToken(token);
return ToJavaString(env, token);
}
LOG(LWARNING, ("nativeAuthWithOAuth2Code: invalid OAuth2 code", oauth2code));
}
catch (std::exception const & ex)
{
LOG(LWARNING, ("nativeAuthWithOAuth2Code error ", ex.what()));
}
return nullptr;
}
JNIEXPORT jstring JNICALL
Java_app_organicmaps_editor_OsmOAuth_nativeGetOsmUsername(JNIEnv * env, jclass, jstring oauthToken)
{

View file

@ -239,6 +239,7 @@ public class Framework
public static native ParsedRoutingData nativeGetParsedRoutingData();
public static native ParsedSearchRequest nativeGetParsedSearchRequest();
public static native @Nullable String nativeGetParsedAppName();
public static native @Nullable String nativeGetParsedOAuth2Code();
@Nullable @Size(2)
public static native double[] nativeGetParsedCenterLatLon();
public static native @Nullable String nativeGetParsedBackUrl();

View file

@ -6,7 +6,7 @@ import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
@Retention(RetentionPolicy.SOURCE)
@IntDef({RequestType.INCORRECT, RequestType.MAP, RequestType.ROUTE, RequestType.SEARCH, RequestType.CROSSHAIR})
@IntDef({RequestType.INCORRECT, RequestType.MAP, RequestType.ROUTE, RequestType.SEARCH, RequestType.CROSSHAIR, RequestType.OAUTH2})
public @interface RequestType
{
// Represents url_scheme::ParsedMapApi::UrlType from c++ part.
@ -15,4 +15,5 @@ public @interface RequestType
public static final int ROUTE = 2;
public static final int SEARCH = 3;
public static final int CROSSHAIR = 4;
public static final int OAUTH2 = 5;
}

View file

@ -1,14 +1,31 @@
package app.organicmaps.editor;
import android.app.Activity;
import android.content.Intent;
import android.os.Bundle;
import androidx.annotation.NonNull;
import androidx.fragment.app.Fragment;
import app.organicmaps.base.BaseMwmFragmentActivity;
public class OsmLoginActivity extends BaseMwmFragmentActivity
{
public static final String EXTRA_OAUTH2CODE = "oauth2code";
@Override
protected Class<? extends Fragment> getFragmentClass()
{
return OsmLoginFragment.class;
}
public static void OAuth2Callback(@NonNull Activity activity, String oauth2code)
{
final Intent i = new Intent(activity, OsmLoginActivity.class);
Bundle args = new Bundle();
args.putString(EXTRA_OAUTH2CODE, oauth2code);
args.putBoolean(ProfileActivity.EXTRA_REDIRECT_TO_PROFILE, true);
i.putExtras(args);
activity.startActivity(i);
}
}

View file

@ -0,0 +1,124 @@
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
package app.organicmaps.editor;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import android.app.Dialog;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import android.os.Bundle;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import android.view.LayoutInflater;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import android.view.View;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import android.view.ViewGroup;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import android.widget.Button;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import android.widget.ProgressBar;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import androidx.annotation.NonNull;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import androidx.annotation.Nullable;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import com.google.android.material.bottomsheet.BottomSheetBehavior;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import com.google.android.material.bottomsheet.BottomSheetDialog;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import com.google.android.material.bottomsheet.BottomSheetDialogFragment;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import com.google.android.material.textfield.TextInputEditText;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import app.organicmaps.R;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import app.organicmaps.util.Constants;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import app.organicmaps.util.InputUtils;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import app.organicmaps.util.UiUtils;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import app.organicmaps.util.Utils;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import app.organicmaps.util.concurrency.ThreadPool;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
import app.organicmaps.util.concurrency.UiThread;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
final private OsmLoginFragment parentFragment;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
private TextInputEditText mLoginInput;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
private TextInputEditText mPasswordInput;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
private Button mLoginButton;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
private Button mLostPasswordButton;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
private Button mRegisterButton;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
private ProgressBar mProgress;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
public OsmLoginBottomFragment(OsmLoginFragment parentFragment)
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
super();
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
this.parentFragment = parentFragment;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
@Override
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
public void onCreate(@Nullable Bundle savedInstanceState)
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
super.onCreate(savedInstanceState);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
@Nullable
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
@Override
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState)
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
return inflater.inflate(R.layout.fragment_osm_login_bottom, container, false);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
@NonNull
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
@Override
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
public Dialog onCreateDialog(Bundle savedInstanceState)
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
BottomSheetDialog dialog = (BottomSheetDialog) super.onCreateDialog(savedInstanceState);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
dialog.getBehavior().setState(BottomSheetBehavior.STATE_EXPANDED);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
return dialog;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
@Override
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState)
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLoginInput = view.findViewById(R.id.osm_username);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mPasswordInput = view.findViewById(R.id.osm_password);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLoginButton = view.findViewById(R.id.login);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLoginButton.setOnClickListener((v) -> doLogin());
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLostPasswordButton = view.findViewById(R.id.lost_password);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLostPasswordButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_RECOVER_PASSWORD));
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mRegisterButton = view.findViewById(R.id.register);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mRegisterButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_REGISTER));
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mProgress = view.findViewById(R.id.osm_login_progress);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
private void doLogin()
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
InputUtils.hideKeyboard(mLoginInput);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
final String username = mLoginInput.getText().toString().trim();
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
final String password = mPasswordInput.getText().toString();
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
enableInput(false);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
UiUtils.show(mProgress);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLoginButton.setText("");
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
ThreadPool.getWorker().execute(() ->
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
final String oauthToken = OsmOAuth.nativeAuthWithPassword(username, password);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
final String username1 = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
UiThread.run(() -> processAuth(oauthToken, username1));
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
});
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
private void processAuth(String oauthToken, String username)
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
if (!isAdded())
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
return;
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
enableInput(true);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
UiUtils.hide(mProgress);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLoginButton.setText(R.string.login_osm);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
if (oauthToken == null)
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
parentFragment.onAuthFail();
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
else
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
this.dismiss();
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
parentFragment.onAuthSuccess(oauthToken, username);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
private void enableInput(boolean enable)
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
{
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mPasswordInput.setEnabled(enable);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLoginInput.setEnabled(enable);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLoginButton.setEnabled(enable);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mLostPasswordButton.setEnabled(enable);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
mRegisterButton.setEnabled(enable);
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class
}
biodranik commented 2024-08-19 18:08:02 +00:00 (Migrated from github.com)
Review
public class OsmLoginBottomFragment extends BottomSheetDialogFragment
{

Please update Android Studio formatter according to our code style and fix it everywhere.

```suggestion public class OsmLoginBottomFragment extends BottomSheetDialogFragment { ``` Please update Android Studio formatter according to our code style and fix it everywhere.
biodranik commented 2024-08-19 18:08:22 +00:00 (Migrated from github.com)
Review

2 spaces instead of 4 everywhere

2 spaces instead of 4 everywhere
biodranik commented 2024-08-19 18:09:08 +00:00 (Migrated from github.com)
Review

Why the text is cleared?

Why the text is cleared?
Review

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like:

vlcsnap-2024-08-20-09h34m13s156

Layout has the button and the progress bar at the same place. When authentication is in progress we disable button and show progress bar. If we don't clear button text it would look like: ![vlcsnap-2024-08-20-09h34m13s156](https://github.com/user-attachments/assets/af1ec057-3c19-4eb4-b925-a64998f34066)
Review

Reformatted this class

Reformatted this class

View file

@ -1,37 +1,34 @@
package app.organicmaps.editor;
import android.content.ActivityNotFoundException;
import android.content.Intent;
import android.net.Uri;
import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.Button;
import android.widget.ProgressBar;
import android.widget.TextView;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import com.google.android.material.dialog.MaterialAlertDialogBuilder;
import app.organicmaps.Framework;
import app.organicmaps.R;
import app.organicmaps.base.BaseMwmToolbarFragment;
import app.organicmaps.util.Constants;
import app.organicmaps.util.DateUtils;
import app.organicmaps.util.InputUtils;
import app.organicmaps.util.UiUtils;
import app.organicmaps.util.Utils;
import app.organicmaps.util.concurrency.ThreadPool;
import app.organicmaps.util.concurrency.UiThread;
import com.google.android.material.dialog.MaterialAlertDialogBuilder;
import com.google.android.material.textfield.TextInputEditText;
public class OsmLoginFragment extends BaseMwmToolbarFragment
{
private ProgressBar mProgress;
private Button mLoginButton;
private Button mLostPasswordButton;
private TextInputEditText mLoginInput;
private TextInputEditText mPasswordInput;
private Button mLoginUsernameButton;
private Button mLoginWebsiteButton;
private String mArgOAuth2Code;
@Nullable
@Override
@ -45,71 +42,85 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
{
super.onViewCreated(view, savedInstanceState);
getToolbarController().setTitle(R.string.login);
mLoginInput = view.findViewById(R.id.osm_username);
mPasswordInput = view.findViewById(R.id.osm_password);
mLoginButton = view.findViewById(R.id.login);
mLoginButton.setOnClickListener((v) -> login());
mLostPasswordButton = view.findViewById(R.id.lost_password);
mLostPasswordButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_RECOVER_PASSWORD));
Button registerButton = view.findViewById(R.id.register);
registerButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_REGISTER));
mProgress = view.findViewById(R.id.osm_login_progress);
mLoginWebsiteButton = view.findViewById(R.id.login_website);
mLoginWebsiteButton.setOnClickListener((v) -> loginWithBrowser());
mLoginUsernameButton = view.findViewById(R.id.login_username);
mLoginUsernameButton.setOnClickListener((v) -> loginUsername());
final String dataVersion = DateUtils.getShortDateFormatter().format(Framework.getDataVersion());
((TextView) view.findViewById(R.id.osm_presentation))
.setText(getString(R.string.osm_presentation, dataVersion));
readArguments();
if (mArgOAuth2Code != null && !mArgOAuth2Code.isEmpty())
continueOAuth2Flow(mArgOAuth2Code);
}
private void login()
private void readArguments()
{
InputUtils.hideKeyboard(mLoginInput);
final String username = mLoginInput.getText().toString().trim();
final String password = mPasswordInput.getText().toString();
enableInput(false);
UiUtils.show(mProgress);
mLoginButton.setText("");
final Bundle arguments = getArguments();
if (arguments == null)
return;
ThreadPool.getWorker().execute(() -> {
final String oauthToken = OsmOAuth.nativeAuthWithPassword(username, password);
final String username1 = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
UiThread.run(() -> processAuth(oauthToken, username1));
});
mArgOAuth2Code = arguments.getString(OsmLoginActivity.EXTRA_OAUTH2CODE);
}
private void enableInput(boolean enable)
private void loginUsername()
{
mPasswordInput.setEnabled(enable);
mLoginInput.setEnabled(enable);
mLoginButton.setEnabled(enable);
mLostPasswordButton.setEnabled(enable);
OsmLoginBottomFragment bottomSheetFragment = new OsmLoginBottomFragment(this);
bottomSheetFragment.show(requireActivity().getSupportFragmentManager(), bottomSheetFragment.getTag());
}
private void processAuth(String oauthToken, String username)
private void loginWithBrowser()
{
Utils.openUri(requireContext(), Uri.parse(OsmOAuth.nativeGetOAuth2Url()));
}
// This method is called by MwmActivity & UrlProcessor when "om://oauth2/osm/callback?code=XXX" is handled
private void continueOAuth2Flow(String oauth2code)
{
if (!isAdded())
return;
if (oauth2code == null || oauth2code.isEmpty())
onAuthFail();
else
{
ThreadPool.getWorker().execute(() -> {
// Finish OAuth2 auth flow and get username for UI.
final String oauthToken = OsmOAuth.nativeAuthWithOAuth2Code(oauth2code);
final String username = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
UiThread.run(() -> {
processAuth(oauthToken, username);
biodranik commented 2024-08-19 11:03:18 +00:00 (Migrated from github.com)
Review

If om://oauth2 scheme is parsed in C++, does it make sense to make the initial URI also on the C++ side? Will it allow reusing of a similar login approach for iOS?

If om://oauth2 scheme is parsed in C++, does it make sense to make the initial URI also on the C++ side? Will it allow reusing of a similar login approach for iOS?
biodranik commented 2024-08-19 11:03:30 +00:00 (Migrated from github.com)
Review
    try
    {
```suggestion try { ```
biodranik commented 2024-08-19 11:03:44 +00:00 (Migrated from github.com)
Review
    }
    catch (ActivityNotFoundException e)
    {
```suggestion } catch (ActivityNotFoundException e) { ```
biodranik commented 2024-08-19 11:04:32 +00:00 (Migrated from github.com)
Review

Showing a toast in hard-coded English here is a good idea. And also logging this as a warning.

Showing a toast in hard-coded English here is a good idea. And also logging this as a warning.
biodranik commented 2024-08-19 11:04:51 +00:00 (Migrated from github.com)
Review

enableInput(true); ?

`enableInput(true);` ?
biodranik commented 2024-08-19 11:05:39 +00:00 (Migrated from github.com)
Review

It would be great to reuse the same login button (GP flavor uses web login, other flavors use password)

It would be great to reuse the same login button (GP flavor uses web login, other flavors use password)
biodranik commented 2024-08-19 11:05:57 +00:00 (Migrated from github.com)
Review
    if (oauth2code == null || oauth2code.length() == 0)
```suggestion if (oauth2code == null || oauth2code.length() == 0) ```
biodranik commented 2024-08-19 11:07:01 +00:00 (Migrated from github.com)
Review

It is called in processAuth below (but after an if)

It is called in processAuth below (but after an if)
Review

You are right. I modified to build OAuth2 URL using native code instead of Java.

You are right. I modified to build OAuth2 URL using native code instead of Java.
Review

Fixed formatting

Fixed formatting
Review

Fixed formatting

Fixed formatting
Review

Changed to .isEmpty()

Changed to `.isEmpty()`
Review

I replaced this code with Utils.openUri(...). It handles missing browser error.

I replaced this code with `Utils.openUri(...)`. It handles missing browser error.
});
});
}
}
public void processAuth(String oauthToken, String username)
{
if (!isAdded())
return;
enableInput(true);
UiUtils.hide(mProgress);
mLoginButton.setText(R.string.login_osm);
if (oauthToken == null)
onAuthFail();
else
onAuthSuccess(oauthToken, username);
}
private void onAuthFail()
public void onAuthFail()
{
new MaterialAlertDialogBuilder(requireActivity(), R.style.MwmTheme_AlertDialog)
.setTitle(R.string.editor_login_error_dialog)
.setPositiveButton(R.string.ok, null)
.show();
.setTitle(R.string.editor_login_error_dialog)
.setPositiveButton(R.string.ok, null)
.show();
}
private void onAuthSuccess(String oauthToken, String username)
public void onAuthSuccess(String oauthToken, String username)
{
OsmOAuth.setAuthorization(requireContext(), oauthToken, username);
final Bundle extras = requireActivity().getIntent().getExtras();
if (extras != null && extras.getBoolean("redirectToProfile", false))
if (extras != null && extras.getBoolean(ProfileActivity.EXTRA_REDIRECT_TO_PROFILE, false))
startActivity(new Intent(requireContext(), ProfileActivity.class));
requireActivity().finish();
}

View file

@ -10,6 +10,8 @@ import androidx.annotation.Size;
import androidx.annotation.WorkerThread;
import androidx.fragment.app.FragmentManager;
import java.util.Map;
import app.organicmaps.MwmApplication;
import app.organicmaps.util.NetworkPolicy;
@ -98,6 +100,12 @@ public final class OsmOAuth
return nativeGetHistoryUrl(getUsername(context));
}
/*
Returns 5 strings: ServerURL, ClientId, ClientSecret, Scope, RedirectUri
*/
@NonNull
public static native String nativeGetOAuth2Url();
/**
* @return string with OAuth2 token
*/
@ -106,6 +114,13 @@ public final class OsmOAuth
@Nullable
public static native String nativeAuthWithPassword(String login, String password);
/**
* @return string with OAuth2 token
*/
@WorkerThread
@Nullable
public static native String nativeAuthWithOAuth2Code(String oauth2code);
@WorkerThread
@Nullable
public static native String nativeGetOsmUsername(String oauthToken);

View file

@ -6,6 +6,8 @@ import app.organicmaps.base.BaseMwmFragmentActivity;
public class ProfileActivity extends BaseMwmFragmentActivity
{
public static final String EXTRA_REDIRECT_TO_PROFILE = "redirectToProfile";
@Override
protected Class<? extends Fragment> getFragmentClass()
{

View file

@ -93,7 +93,7 @@ public class ProfileFragment extends BaseMwmToolbarFragment
else
{
Intent intent = new Intent(requireContext(), OsmLoginActivity.class);
intent.putExtra("redirectToProfile", true);
intent.putExtra(ProfileActivity.EXTRA_REDIRECT_TO_PROFILE, true);
startActivity(intent);
requireActivity().finish();
}

View file

@ -3,6 +3,7 @@ package app.organicmaps.intent;
import android.content.ContentResolver;
import android.content.Intent;
import android.net.Uri;
import android.util.Log;
import androidx.annotation.NonNull;
import androidx.core.content.IntentCompat;
@ -18,6 +19,7 @@ import app.organicmaps.api.RoutePoint;
import app.organicmaps.bookmarks.data.BookmarkManager;
import app.organicmaps.bookmarks.data.FeatureId;
import app.organicmaps.bookmarks.data.MapObject;
import app.organicmaps.editor.OsmLoginActivity;
import app.organicmaps.routing.RoutingController;
import app.organicmaps.search.SearchActivity;
import app.organicmaps.search.SearchEngine;
@ -128,6 +130,15 @@ public class Factory
Framework.nativeSetViewportCenter(latlon[0], latlon[1], SEARCH_IN_VIEWPORT_ZOOM);
}
return true;
}
case RequestType.OAUTH2:
{
SearchEngine.INSTANCE.cancelInteractiveSearch();
final String oauth2code = Framework.nativeGetParsedOAuth2Code();
OsmLoginActivity.OAuth2Callback(target, oauth2code);
return true;
}
}

View file

@ -63,119 +63,32 @@
<androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_half">
<com.google.android.material.textfield.TextInputLayout
android:id="@+id/osm_username_container"
style="@style/MwmWidget.Editor.CustomTextInput"
android:layout_width="0dp"
android:layout_marginEnd="@dimen/margin_half"
android:textColorHint="?android:textColorSecondary"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toStartOf="@id/osm_password_container"
app:layout_constraintTop_toTopOf="parent"
app:endIconMode="custom">
<com.google.android.material.textfield.TextInputEditText
android:id="@+id/osm_username"
style="@style/MwmWidget.Editor.FieldLayout.EditText"
android:autofillHints="emailAddress"
android:hint="@string/email_or_username" />
</com.google.android.material.textfield.TextInputLayout>
<com.google.android.material.textfield.TextInputLayout
android:id="@+id/osm_password_container"
style="@style/MwmWidget.Editor.CustomTextInput"
android:layout_width="0dp"
android:textColorHint="?android:textColorSecondary"
app:layout_constraintStart_toEndOf="@id/osm_username_container"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:endIconMode="password_toggle"
app:endIconTint="?android:textColorSecondary">
<com.google.android.material.textfield.TextInputEditText
android:id="@+id/osm_password"
style="@style/MwmWidget.Editor.FieldLayout.EditText"
android:autofillHints="password"
android:hint="@string/password"
android:inputType="textPassword" />
</com.google.android.material.textfield.TextInputLayout>
</androidx.constraintlayout.widget.ConstraintLayout>
<androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/margin_base">
<FrameLayout
android:id="@+id/login_container"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@id/lost_password"
app:layout_constraintTop_toTopOf="parent">
<Button
android:id="@+id/login"
style="@style/MwmWidget.Button.Accent"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="@string/login_osm"
android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
<ProgressBar
android:id="@+id/osm_login_progress"
android:layout_width="@dimen/editor_auth_btn_height"
android:layout_height="@dimen/editor_auth_btn_height"
android:layout_gravity="center"
android:elevation="@dimen/design_fab_elevation"
android:visibility="gone" />
</FrameLayout>
<Button
android:id="@+id/lost_password"
style="@style/MwmWidget.Button"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:background="?clickableBackground"
android:gravity="start|center_vertical"
android:padding="@dimen/margin_half"
android:text="@string/forgot_password"
android:textAppearance="@style/MwmTextAppearance.Body3"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@id/login_container"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout>
<com.google.android.material.divider.MaterialDivider
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_base"
android:layout_marginBottom="@dimen/margin_base" />
<androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent"
android:layout_height="wrap_content">
<TextView
android:id="@+id/register_text"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:fontFamily="@string/robotoRegular"
android:gravity="start|center_vertical"
android:text="@string/no_osm_account"
android:textAppearance="@style/MwmTextAppearance.Body2"
android:textColor="?android:textColorPrimary"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@id/register"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
android:layout_marginBottom="@dimen/margin_base">
<Button
android:id="@+id/register"
android:id="@+id/login_website"
style="@style/MwmWidget.Button.Accent"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:background="@drawable/button_editor_light"
android:fontFamily="@string/robotoMedium"
android:padding="@dimen/margin_quarter"
android:text="@string/register_at_openstreetmap"
android:textAppearance="@style/MwmTextAppearance.Body2"
android:textColor="@color/text_dark"
android:padding="@dimen/margin_half"
android:layout_marginEnd="@dimen/margin_base"
android:text="Login with OSM website"
android:textAppearance="@style/MwmTextAppearance.Body2.Light"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@id/register_text"
app:layout_constraintEnd_toStartOf="@id/login_username"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
<Button
android:id="@+id/login_username"
style="@style/MwmWidget.Button.Accent"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:text="Login with username"
android:textAppearance="@style/MwmTextAppearance.Body2.Light"
app:layout_constraintStart_toEndOf="@id/login_website"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout>
</LinearLayout>
</ScrollView>

View file

@ -0,0 +1,117 @@
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical">
<include
layout="@layout/bottom_sheet_handle" />
<ScrollView
android:layout_width="match_parent"
android:layout_height="match_parent"
android:background="?cardBackground"
android:fadeScrollbars="false"
android:fillViewport="true"
tools:ignore="DuplicateIds">
<LinearLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
android:clipChildren="false"
android:clipToPadding="false"
android:orientation="vertical"
android:padding="@dimen/margin_base"
tools:ignore="ScrollViewSize">
<androidx.constraintlayout.widget.ConstraintLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_half">
<com.google.android.material.textfield.TextInputLayout
android:id="@+id/osm_username_container"
style="@style/MwmWidget.Editor.CustomTextInput"
android:layout_width="0dp"
android:layout_marginEnd="@dimen/margin_half"
android:textColorHint="?android:textColorSecondary"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toStartOf="@id/osm_password_container"
app:layout_constraintTop_toTopOf="parent"
app:endIconMode="custom">
<com.google.android.material.textfield.TextInputEditText
android:id="@+id/osm_username"
style="@style/MwmWidget.Editor.FieldLayout.EditText"
android:autofillHints="emailAddress"
android:hint="@string/email_or_username" />
</com.google.android.material.textfield.TextInputLayout>
<com.google.android.material.textfield.TextInputLayout
android:id="@+id/osm_password_container"
style="@style/MwmWidget.Editor.CustomTextInput"
android:layout_width="0dp"
android:textColorHint="?android:textColorSecondary"
app:layout_constraintStart_toEndOf="@id/osm_username_container"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:endIconMode="password_toggle"
app:endIconTint="?android:textColorSecondary">
<com.google.android.material.textfield.TextInputEditText
android:id="@+id/osm_password"
style="@style/MwmWidget.Editor.FieldLayout.EditText"
android:autofillHints="password"
android:hint="@string/password"
android:inputType="textPassword" />
</com.google.android.material.textfield.TextInputLayout>
</androidx.constraintlayout.widget.ConstraintLayout>
<FrameLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_base">
<Button
android:id="@+id/login"
style="@style/MwmWidget.Button.Accent"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="Login with username"
android:layout_marginTop="@dimen/margin_half"
android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
<ProgressBar
android:id="@+id/osm_login_progress"
android:layout_width="@dimen/editor_auth_btn_height"
android:layout_height="@dimen/editor_auth_btn_height"
android:layout_gravity="center"
android:elevation="@dimen/design_fab_elevation"
android:visibility="gone" />
</FrameLayout>
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal"
android:layout_marginTop="@dimen/margin_base">
<Button
android:id="@+id/lost_password"
style="@style/MwmWidget.Button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="start"
android:layout_weight="1"
android:background="?clickableBackground"
android:padding="@dimen/margin_quarter"
android:text="@string/forgot_password"
android:textAppearance="@style/MwmTextAppearance.Body3" />
<Button
android:id="@+id/register"
style="@style/MwmWidget.Button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_weight="1"
android:layout_gravity="end"
android:background="?clickableBackground"
android:padding="@dimen/margin_quarter"
android:text="@string/register_at_openstreetmap"
android:textAppearance="@style/MwmTextAppearance.Body3" />
</LinearLayout>
</LinearLayout>
</ScrollView>
</LinearLayout>

View file

@ -60,83 +60,22 @@
android:text="@string/login_to_make_edits_visible"
android:textAppearance="@style/MwmTextAppearance.Body2"
android:textColor="?android:textColorPrimary" />
<com.google.android.material.textfield.TextInputLayout
style="@style/MwmWidget.Editor.CustomTextInput"
android:layout_marginTop="@dimen/margin_half"
android:textColorHint="?android:textColorSecondary"
app:endIconMode="custom">
<com.google.android.material.textfield.TextInputEditText
android:id="@+id/osm_username"
style="@style/MwmWidget.Editor.FieldLayout.EditText"
android:autofillHints="emailAddress"
android:hint="@string/email_or_username" />
</com.google.android.material.textfield.TextInputLayout>
<com.google.android.material.textfield.TextInputLayout
style="@style/MwmWidget.Editor.CustomTextInput"
<Button
android:id="@+id/login_website"
style="@style/MwmWidget.Button.Accent"
android:layout_marginTop="@dimen/margin_base"
android:textColorHint="?android:textColorSecondary"
app:endIconMode="password_toggle"
app:endIconTint="?android:textColorSecondary">
<com.google.android.material.textfield.TextInputEditText
android:id="@+id/osm_password"
style="@style/MwmWidget.Editor.FieldLayout.EditText"
android:autofillHints="password"
android:hint="@string/password"
android:inputType="textPassword" />
</com.google.android.material.textfield.TextInputLayout>
<FrameLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginBottom="@dimen/margin_base">
<Button
android:id="@+id/login"
style="@style/MwmWidget.Button.Accent"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="@string/login_osm"
android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
<ProgressBar
android:id="@+id/osm_login_progress"
android:layout_width="@dimen/editor_auth_btn_height"
android:layout_height="@dimen/editor_auth_btn_height"
android:layout_gravity="center"
android:elevation="@dimen/design_fab_elevation"
android:visibility="gone" />
</FrameLayout>
android:text="Login with OSM website"
android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
<Button
android:id="@+id/lost_password"
style="@style/MwmWidget.Button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="end"
android:background="?clickableBackground"
android:padding="@dimen/margin_half"
android:text="@string/forgot_password"
android:textAppearance="@style/MwmTextAppearance.Body3" />
<com.google.android.material.divider.MaterialDivider
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_base"
android:layout_marginBottom="@dimen/margin_base" />
<TextView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:fontFamily="@string/robotoRegular"
android:text="@string/no_osm_account"
android:textAppearance="@style/MwmTextAppearance.Body2"
android:textColor="?android:textColorPrimary" />
<Button
android:id="@+id/register"
android:id="@+id/login_username"
style="@style/MwmWidget.Button.Accent"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="Login with username"
android:layout_marginTop="@dimen/margin_base"
android:background="@drawable/button_editor_light"
android:fontFamily="@string/robotoMedium"
android:padding="@dimen/margin_quarter"
android:text="@string/register_at_openstreetmap"
android:textAppearance="@style/MwmTextAppearance.Body2"
android:textColor="@color/text_dark" />
android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
</LinearLayout>
</ScrollView>
</LinearLayout>

View file

@ -0,0 +1,110 @@
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<?xml version="1.0" encoding="utf-8"?>
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<LinearLayout
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
xmlns:android="http://schemas.android.com/apk/res/android"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
xmlns:app="http://schemas.android.com/apk/res-auto"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
xmlns:tools="http://schemas.android.com/tools"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:orientation="vertical">
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<include
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
layout="@layout/bottom_sheet_handle" />
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<ScrollView
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:background="?cardBackground"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:fadeScrollbars="false"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:fillViewport="true"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
tools:ignore="DuplicateIds">
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<LinearLayout
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:clipChildren="false"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:clipToPadding="false"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:orientation="vertical"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:padding="@dimen/margin_base"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
tools:ignore="ScrollViewSize">
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<LinearLayout
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:id="@+id/login_bottom_sheet"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="wrap_content"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:orientation="vertical">
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<com.google.android.material.textfield.TextInputLayout
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
style="@style/MwmWidget.Editor.CustomTextInput"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_marginTop="@dimen/margin_half"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:textColorHint="?android:textColorSecondary"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
app:endIconMode="custom">
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<com.google.android.material.textfield.TextInputEditText
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:id="@+id/osm_username"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
style="@style/MwmWidget.Editor.FieldLayout.EditText"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:padding="@dimen/margin_half_double_plus"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:autofillHints="emailAddress"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:hint="@string/email_or_username" />
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
</com.google.android.material.textfield.TextInputLayout>
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<com.google.android.material.textfield.TextInputLayout
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
style="@style/MwmWidget.Editor.CustomTextInput"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:textColorHint="?android:textColorSecondary"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
app:endIconMode="password_toggle"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
app:endIconTint="?android:textColorSecondary">
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<com.google.android.material.textfield.TextInputEditText
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:id="@+id/osm_password"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
style="@style/MwmWidget.Editor.FieldLayout.EditText"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:padding="@dimen/margin_half_double_plus"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:autofillHints="password"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:hint="@string/password"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:inputType="textPassword" />
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
</com.google.android.material.textfield.TextInputLayout>
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
</LinearLayout>
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<FrameLayout
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="wrap_content"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_marginTop="@dimen/margin_base">
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<Button
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:id="@+id/login"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
style="@style/MwmWidget.Button.Accent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="wrap_content"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:text="Login with username"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_marginTop="@dimen/margin_half"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<ProgressBar
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:id="@+id/osm_login_progress"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="@dimen/editor_auth_btn_height"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="@dimen/editor_auth_btn_height"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_gravity="center"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:elevation="@dimen/design_fab_elevation"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:visibility="gone" />
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
</FrameLayout>
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<LinearLayout
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="match_parent"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="wrap_content"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:orientation="horizontal"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_marginTop="@dimen/margin_base">
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<Button
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:id="@+id/lost_password"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
style="@style/MwmWidget.Button"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="wrap_content"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="wrap_content"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_gravity="start"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_weight="1"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:background="?clickableBackground"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:padding="@dimen/margin_quarter"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:text="@string/forgot_password"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:textAppearance="@style/MwmTextAppearance.Body3" />
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
<Button
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:id="@+id/register"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
style="@style/MwmWidget.Button"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_width="wrap_content"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_height="wrap_content"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_weight="1"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:layout_gravity="end"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:background="?clickableBackground"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:padding="@dimen/margin_quarter"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:text="@string/register_at_openstreetmap"
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
android:textAppearance="@style/MwmTextAppearance.Body3" />
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
</LinearLayout>
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
</LinearLayout>
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
</ScrollView>
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting
</LinearLayout>
biodranik commented 2024-08-19 18:10:12 +00:00 (Migrated from github.com)
Review

?

?
biodranik commented 2024-08-19 18:10:32 +00:00 (Migrated from github.com)
Review

For some reason, formatting is inconsistent.

For some reason, formatting is inconsistent.
Review

Fixed formatting

Fixed formatting
Review

Fixed XML formatting

Fixed XML formatting

View file

@ -241,14 +241,7 @@ string OsmOAuth::SendAuthRequest(string const & requestTokenKey, SessionID const
string OsmOAuth::FetchRequestToken(SessionID const & sid) const
{
string const requestTokenUrl = m_baseUrl + "/oauth2/authorize";
string const requestTokenQuery = BuildPostRequest({
{"client_id", m_oauth2params.m_clientId},
{"redirect_uri", m_oauth2params.m_redirectUri},
{"scope", m_oauth2params.m_scope},
{"response_type", "code"}
});
HttpClient request(requestTokenUrl + "?" + requestTokenQuery);
HttpClient request(BuildOAuth2Url());
request.SetCookies(sid.m_cookies)
.SetFollowRedirects(false);
@ -280,6 +273,18 @@ string OsmOAuth::FetchRequestToken(SessionID const & sid) const
}
}
string OsmOAuth::BuildOAuth2Url() const
{
string requestTokenUrl = m_baseUrl + "/oauth2/authorize";
string const requestTokenQuery = BuildPostRequest({
{"client_id", m_oauth2params.m_clientId},
{"redirect_uri", m_oauth2params.m_redirectUri},
{"scope", m_oauth2params.m_scope},
{"response_type", "code"}
});
return requestTokenUrl.append("?").append(requestTokenQuery);
}
string OsmOAuth::FinishAuthorization(string const & oauth2code) const
{
auto params = BuildPostRequest({

View file

@ -93,6 +93,13 @@ public:
/// @param[api] If false, request is made to m_baseUrl.
Response DirectRequest(std::string const & method, bool api = true) const;
// Getters
std::string GetBaseUrl() const { return m_baseUrl; }
std::string GetClientId() const { return m_oauth2params.m_clientId; }
std::string GetClientSecret() const { return m_oauth2params.m_clientSecret; }
std::string GetScope() const { return m_oauth2params.m_scope; }
std::string GetRedirectUri() const { return m_oauth2params.m_redirectUri; }
/// @name Methods for WebView-based authentication.
//@{
std::string FinishAuthorization(std::string const & oauth2code) const;
@ -102,6 +109,7 @@ public:
{
return m_baseUrl + "/user/" + user + "/history";
}
std::string BuildOAuth2Url() const;
//@}
private:
@ -136,7 +144,6 @@ private:
/// @returns valid key and secret or throws otherwise.
std::string FetchRequestToken(SessionID const & sid) const;
std::string FetchAccessToken(SessionID const & sid) const;
//AuthResult FetchAccessToken(SessionID const & sid);
};
std::string DebugPrint(OsmOAuth::Response const & code);

View file

@ -8,6 +8,7 @@ typedef NS_ENUM(NSUInteger, DeeplinkUrlType) {
DeeplinkUrlTypeRoute,
DeeplinkUrlTypeSearch,
DeeplinkUrlTypeCrosshair,
DeeplinkUrlTypeOAuth2
};
@interface DeepLinkParser : NSObject

View file

@ -13,6 +13,7 @@ static inline DeeplinkUrlType deeplinkUrlType(url_scheme::ParsedMapApi::UrlType
case url_scheme::ParsedMapApi::UrlType::Route: return DeeplinkUrlTypeRoute;
case url_scheme::ParsedMapApi::UrlType::Search: return DeeplinkUrlTypeSearch;
case url_scheme::ParsedMapApi::UrlType::Crosshair: return DeeplinkUrlTypeCrosshair;
case url_scheme::ParsedMapApi::UrlType::OAuth2: return DeeplinkUrlTypeOAuth2;
}
}

View file

@ -115,6 +115,10 @@
case .crosshair:
// Not supported on iOS.
return false;
case .oAuth2:
// TODO: support OAuth2
return false;
case .incorrect:
// Invalid URL or API parameters.

View file

@ -1738,6 +1738,11 @@ url_scheme::SearchRequest Framework::GetParsedSearchRequest() const
return m_parsedMapApi.GetSearchRequest();
}
std::string Framework::GetParsedOAuth2Code() const
{
return m_parsedMapApi.GetOAuth2Code();
}
std::string const & Framework::GetParsedAppName() const
{
return m_parsedMapApi.GetAppName();

View file

@ -578,6 +578,7 @@ public:
ParsedRoutingData GetParsedRoutingData() const;
url_scheme::SearchRequest GetParsedSearchRequest() const;
std::string GetParsedOAuth2Code() const;
std::string const & GetParsedAppName() const;
std::string const & GetParsedBackUrl() const;
ms::LatLon GetParsedCenterLatLon() const;

View file

@ -474,6 +474,23 @@ UNIT_TEST(AppNameTest)
}
}
UNIT_TEST(OAuth2Test)
{
{
ParsedMapApi api("om://oauth2/osm/callback?code=THE_MEGA_CODE");
TEST_EQUAL(api.GetRequestType(), UrlType::OAuth2, ());
TEST_EQUAL(api.GetOAuth2Code(), "THE_MEGA_CODE", ());
}
{
ParsedMapApi api("om://oauth2/google/callback?code=THE_MEGA_CODE");
TEST_EQUAL(api.GetRequestType(), UrlType::Incorrect, ());
}
{
ParsedMapApi api("om://oauth2/osm/callback?code=");
TEST_EQUAL(api.GetRequestType(), UrlType::Incorrect, ());
}
}
namespace
{
string generatePartOfUrl(url_scheme::MapPoint const & point)

View file

@ -175,6 +175,22 @@ ParsedMapApi::UrlType ParsedMapApi::SetUrlAndParse(std::string const & raw)
return m_requestType = UrlType::Crosshair;
}
else if (type == "oauth2")
{
if (url.GetPath() != "osm/callback")
return m_requestType = UrlType::Incorrect;
url.ForEachParam([this](auto const & key, auto const & value)
{
if (key == "code")
m_oauth2code = value;
});
if (m_oauth2code.empty())
return m_requestType = UrlType::Incorrect;
else
return m_requestType = UrlType::OAuth2;
}
else if (checkForGe0Link)
{
// The URL is prefixed by one of the kGe0Prefixes AND doesn't match any supported API call:
@ -386,6 +402,7 @@ void ParsedMapApi::Reset()
m_mapPoints.clear();
m_routePoints.clear();
m_searchRequest = {};
m_oauth2code = {};
m_globalBackUrl ={};
m_appName = {};
m_centerLatLon = ms::LatLon::Invalid();
@ -467,6 +484,7 @@ std::string DebugPrint(ParsedMapApi::UrlType type)
case ParsedMapApi::UrlType::Route: return "Route";
case ParsedMapApi::UrlType::Search: return "Search";
case ParsedMapApi::UrlType::Crosshair: return "Crosshair";
case ParsedMapApi::UrlType::OAuth2: return "OAuth2";
}
UNREACHABLE();
}

View file

@ -45,6 +45,7 @@ public:
Route = 2,
Search = 3,
Crosshair = 4,
OAuth2 = 5,
};
ParsedMapApi() = default;
@ -93,6 +94,12 @@ public:
return m_searchRequest;
}
std::string const & GetOAuth2Code() const
{
ASSERT_EQUAL(m_requestType, UrlType::OAuth2, ("Expected OAuth2 API"));
return m_oauth2code;
}
private:
void ParseMapParam(std::string const & key, std::string const & value,
bool & correctOrder);
@ -107,6 +114,7 @@ private:
SearchRequest m_searchRequest;
std::string m_globalBackUrl;
std::string m_appName;
std::string m_oauth2code;
ms::LatLon m_centerLatLon = ms::LatLon::Invalid();
std::string m_routingType;
int m_version = 0;