Added prison to categories.txt #9475

patepelo · 2024-10-08T14:01:20Z

ProgramminCat commented

2024-10-08 14:01:20 +00:00

(Migrated from github.com)

Resolves #9121

👍 2

vng (Migrated from github.com) approved these changes 2024-10-09 19:56:39 +00:00

vng (Migrated from github.com) left a comment

Can't imagine who cares about the "prison" search category, but technically PR is ok ..

andergd (Migrated from github.com) requested changes 2024-10-09 20:17:14 +00:00

data/categories.txt

					
				@ -16695,2 +16695,4 @@

				zh-Hans:艺术中心

				zh-Hant:藝術中心

				amenity-prison

andergd (Migrated from github.com) commented

2024-10-09 20:16:51 +00:00

Cannot PR but here it is in Spanish:

es:cárcel

And I don't know if will be used but also in Basque:

eu:espetxe

Cannot PR but here it is in Spanish: `es:cárcel` And I don't know if will be used but also in Basque: `eu:espetxe`

biodranik (Migrated from github.com) reviewed 2024-10-09 20:21:01 +00:00

data/categories.txt

					
				@ -16695,2 +16695,4 @@

				zh-Hans:艺术中心

				zh-Hant:藝術中心

				amenity-prison

biodranik (Migrated from github.com) commented

2024-10-09 20:21:01 +00:00

en:prison
ar:السجن
be:турма
bg:затвор
ca:presó
cs:vězení
da:Fængsel
de:Gefängnis
el:φυλακή
es:cárcel|prisión
et:vangla
eu:espetxe|kartzela
fa:زندان
fi:vankila
fr:prison
he:בית כלא
hi:कारागार
hu:börtön
id:penjara
it:prigione
ja:刑務所
ko:감옥
mr:तुरुंग
nb:fengsel
nl:gevangenis
pl:więzienie
pt:prisão
ro:închisoare
ru:тюрьма
sk:väzenie
sv:fängelse
sw:jela
th:คุก
tr:hapishane
uk:в'язниця
vi:nhà tù
zh-Hans:监狱
zh-Hant:監獄

en:prison ar:السجن be:турма bg:затвор ca:presó cs:vězení da:Fængsel de:Gefängnis el:φυλακή es:cárcel|prisión et:vangla eu:espetxe|kartzela fa:زندان fi:vankila fr:prison he:בית כלא hi:कारागार hu:börtön id:penjara it:prigione ja:刑務所 ko:감옥 mr:तुरुंग nb:fengsel nl:gevangenis pl:więzienie pt:prisão ro:închisoare ru:тюрьма sk:väzenie sv:fängelse sw:jela th:คุก tr:hapishane uk:в'язниця vi:nhà tù zh-Hans:监狱 zh-Hant:監獄

NeatNit (Migrated from github.com) reviewed 2024-10-09 20:34:55 +00:00

data/categories.txt

					
				@ -16695,2 +16695,4 @@

				zh-Hans:艺术中心

				zh-Hant:藝術中心

				amenity-prison

NeatNit (Migrated from github.com) commented

2024-10-09 20:34:55 +00:00

Hebrew (he): בית כלא

biodranik (Migrated from github.com) reviewed 2024-10-09 20:52:36 +00:00

data/categories.txt

					
				@ -16695,2 +16695,4 @@

				zh-Hans:艺术中心

				zh-Hant:藝術中心

				amenity-prison

biodranik (Migrated from github.com) commented

2024-10-09 20:52:35 +00:00

@NeatNit what's the difference with the autotranslation?

NeatNit (Migrated from github.com) reviewed 2024-10-09 21:00:21 +00:00

data/categories.txt

					
				@ -16695,2 +16695,4 @@

				zh-Hans:艺术中心

				zh-Hant:藝術中心

				amenity-prison

NeatNit (Migrated from github.com) commented

2024-10-09 21:00:21 +00:00

@NeatNit what's the difference with the autotranslation?

Removal of Nikkud for one thing (the tiny dots and symbols around the letters), but the bigger difference is, my suggestion is the full term for prison (loosely "house of imprisonment") whereas the auto-translation is just the last word. It can be used on its own to mean pretty much the same thing but in my subjective opinion, my suggestion is the clearer term.

If you insist on the one-word name, then at least remove Nikkud: כלא

> @NeatNit what's the difference with the autotranslation? Removal of Nikkud for one thing (the tiny dots and symbols around the letters), but the bigger difference is, my suggestion is the full term for prison (loosely "house of imprisonment") whereas the auto-translation is just the last word. It *can* be used on its own to mean pretty much the same thing but in my subjective opinion, my suggestion is the clearer term. If you insist on the one-word name, then at least remove Nikkud: כלא

biodranik (Migrated from github.com) reviewed 2024-10-09 21:28:14 +00:00

data/categories.txt

					
				@ -16695,2 +16695,4 @@

				zh-Hans:艺术中心

				zh-Hant:藝術中心

				amenity-prison

biodranik (Migrated from github.com) commented

2024-10-09 21:28:14 +00:00

This is for search, so two or more words/synonyms should be added (what users likely type in the search input box). Can you please write the final he:...|... string with all synonyms?

muralito (Migrated from github.com) requested changes 2024-10-10 00:59:53 +00:00

muralito (Migrated from github.com) left a comment

Please add this spanish search terms for "prison"

jimcarst (Migrated from github.com) reviewed 2024-10-10 10:06:40 +00:00

data/categories.txt

					
				@ -16695,2 +16695,4 @@

				zh-Hans:艺术中心

				zh-Hant:藝術中心

				amenity-prison

jimcarst (Migrated from github.com) commented

2024-10-10 10:06:40 +00:00

nl is ok. There are too many synonyms and only this one is suitable for search.

vng (Migrated from github.com) reviewed 2024-10-10 12:06:53 +00:00

data/categories.txt

vng (Migrated from github.com) commented

2024-10-10 12:06:47 +00:00

Due to the special categories processing better to remove "centro penitenciario|centro de reclusión" for sure.

Adding a bunch of synonyms won't make the search better (especially for exotic categories like prison) but may lead to unexpected search results. Please, keep a reasonable tradeoff here and leave 2-3 most common terms, but don't push the whole synonyms vocabulary.

Due to the special categories processing better to remove "centro penitenciario|centro de reclusión" for sure. Adding a bunch of synonyms won't make the search better (especially for exotic categories like prison) but may lead to unexpected search results. Please, keep a reasonable tradeoff here and leave 2-3 most common terms, but don't push the whole synonyms vocabulary.

patepelo reviewed 2024-10-10 12:10:14 +00:00

data/categories.txt

patepelo commented

2024-10-10 12:10:14 +00:00

Totally agree, wantes to comment on this. This undermines search performance and accuracy.

Plese keep only: prisión|cárcel

Totally agree, wantes to comment on this. This undermines search performance and accuracy. Plese keep only: prisión|cárcel

muralito (Migrated from github.com) reviewed 2024-10-10 16:03:42 +00:00

data/categories.txt

muralito (Migrated from github.com) commented

2024-10-10 16:03:42 +00:00

Just remove them if it hurts performance, but the Spanish language is just like it is, with lots of variants and synonyms. I don't know statistics for the everyday use of those terms to choose which ones suits best for the use case. In worst case, the user would try searching for several of them until he gets the results.

NeatNit (Migrated from github.com) reviewed 2024-10-11 11:43:08 +00:00

data/categories.txt

					
				@ -16695,2 +16695,4 @@

				zh-Hans:艺术中心

				zh-Hant:藝術中心

				amenity-prison

NeatNit (Migrated from github.com) commented

2024-10-11 11:43:08 +00:00

This is for search, so two or more words/synonyms should be added (what users likely type in the search input box). Can you please write the final he:...|... string with all synonyms?

Sorry, I missed this message until now.

he:כלא|בית כלא|בית סוהר

> This is for search, so two or more words/synonyms should be added (what users likely type in the search input box). Can you please write the final he:...|... string with all synonyms? Sorry, I missed this message until now. he:כלא|בית כלא|בית סוהר

Ghost approved these changes 2024-10-11 21:46:37 +00:00

data/categories.txt

					
				@ -16697,0 +16710,4 @@

				eu:espetxe|kartzela

				fa:زندان

				fi:vankila

				fr:prison

Ghost commented

2024-10-11 21:46:32 +00:00

LGTM

pastk reviewed 2024-10-12 15:08:35 +00:00

data/categories.txt

pastk commented

2024-10-12 15:08:12 +00:00

en:prison
ar:السجن
be:турма
bg:затвор
ca:presó
cs:vězení
da:Fængsel
de:Gefängnis
el:φυλακή
es:prisión|cárcel
et:vangla
eu:espetxe|kartzela
fa:زندان
fi:vankila
fr:prison
he:כלא|בית כלא|בית סוהר
hi:कारागार
hu:börtön
id:penjara
it:prigione
ja:刑務所
ko:감옥
lv:cietums
mr:तुरुंग
nb:fengsel
nl:gevangenis
pl:więzienie
pt:prisão
ro:închisoare
ru:тюрьма
sk:väzenie
sv:fängelse
sw:jela
th:คุก
tr:hapishane
uk:в'язниця
vi:nhà tù
zh-Hans:监狱

Re-sorted all lines

```suggestion en:prison ar:السجن be:турма bg:затвор ca:presó cs:vězení da:Fængsel de:Gefängnis el:φυλακή es:prisión|cárcel et:vangla eu:espetxe|kartzela fa:زندان fi:vankila fr:prison he:כלא|בית כלא|בית סוהר hi:कारागार hu:börtön id:penjara it:prigione ja:刑務所 ko:감옥 lv:cietums mr:तुरुंग nb:fengsel nl:gevangenis pl:więzienie pt:prisão ro:închisoare ru:тюрьма sk:väzenie sv:fängelse sw:jela th:คุก tr:hapishane uk:в'язниця vi:nhà tù zh-Hans:监狱 ``` Re-sorted all lines

pastk approved these changes 2024-10-12 18:38:54 +00:00

Colonel-Dixie (Migrated from github.com) reviewed 2024-10-16 03:16:59 +00:00

data/categories.txt

					
				@ -16697,0 +16697,4 @@

				amenity-prison

				en:prison

				ar:السجن

Colonel-Dixie (Migrated from github.com) commented

2024-10-16 03:16:59 +00:00

ar:السجن needs improvement, it translate to "the prison"
The correct one should be ar:سجن which is just " prison.

ar:السجن needs improvement, it translate to "the prison" The correct one should be ar:سجن which is just " prison.

pastk reviewed 2024-10-22 20:36:45 +00:00

data/categories.txt

					
				@ -16697,0 +16697,4 @@

				amenity-prison

				en:prison

				ar:السجن

pastk commented

2024-10-22 20:36:45 +00:00

Thanks!
organicmaps/organicmaps#9555

Thanks! https://git.omaps.dev/organicmaps/organicmaps/pulls/9555

This repo is archived. You cannot comment on pull requests.

No reviewers

vng

andergd

muralito

pastk

No labels

Android Automotive (AAOS)

API

AppGallery

AppStore

Battery and Performance

External Map Datasets

F-Droid

Fonts

Frequently User Reported

No milestone

No project

No assignees

3 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#9475

Rows
Columns