[style] Change rendering of abandoned and disused railways #9758

map-per · 2024-11-26T22:31:28Z

IdeallyGrey commented

2024-11-26 22:31:28 +00:00

(Migrated from github.com)

This PR swaps the rendering of railway=abandoned and railway=disused to better reflect the current state of railways in the map. According to the OSM wiki abandoned tracks are physically present but no longer used, while disused tracks were once present but since dismantled. Currently, OM renders disused in a more prominent style than abandoned ones, even though they are no longer there.
By swapping them the real situation will better be represented.
Closes #8662

This PR swaps the rendering of `railway=abandoned` and `railway=disused` to better reflect the current state of railways in the map. According to the OSM wiki `abandoned` tracks are physically present but no longer used, while `disused` tracks were once present but since dismantled. Currently, OM renders `disused` in a more prominent style than `abandoned` ones, even though they are no longer there. By swapping them the real situation will better be represented. Closes #8662

👍 2

map-per reviewed 2024-11-29 07:24:37 +00:00

map-per left a comment

The style change looks good (the current behavior of displaying abandoned more prominent than disused doesn't make sense)

I would also swap the bridge casing style. It's defined in the same file with [railway=abandoned][bridge?]::bridgewhite and [railway=abandoned][bridge?]::bridgeblack.

The style change looks good (the current behavior of displaying abandoned more prominent than disused doesn't make sense) I would also swap the bridge casing style. It's defined in the same file with [railway=abandoned][bridge?]::bridgewhite and [railway=abandoned][bridge?]::bridgeblack.

pastk reviewed 2024-12-06 17:15:52 +00:00

data/mapcss-mapping.csv

					
				@ -399,3 +398,3 @@

				railway|abandoned|bridge;[railway=abandoned][bridge?];;name;int_name;298;

				railway|disused|bridge;[railway=disused][bridge?];;name;int_name;298;

				man_made|lighthouse;299;

				deprecated:highway|path|demanding_mountain_hiking:04.2024;[highway=path][sac_scale=demanding_mountain_hiking];x;name;int_name;300;highway|path|difficult

pastk commented

2024-12-06 17:11:31 +00:00

actually a railway=abandoned bridge=yes is not a mismapping, its a legit situation, e.g. rails were removed but bridge is still there with some sleepers, posts and maybe other remnants left...
according to https://taginfo.openstreetmap.org/tags/railway=abandoned#combinations there are 37k abandoned railway bridges mapped (9% of all abandoned railways)

actually a `railway=abandoned bridge=yes` is not a mismapping, its a legit situation, e.g. rails were removed but bridge is still there with some sleepers, posts and maybe other remnants left... according to https://taginfo.openstreetmap.org/tags/railway=abandoned#combinations there are 37k abandoned railway bridges mapped (9% of all abandoned railways)

pastk commented

2024-12-06 17:15:46 +00:00

Ideally we'd have separate rendering styles for abandoned and disused bridges which would be similar to abandoned and disused lines respectively. Then we'll need to add translations into types_strings.txt also.

If you feel its too much to do then I think its fine to combine both of them into a single style, e.g.
railway|abandoned|bridge;[railway=abandoned][bridge?],[railway=disused][bridge?];;name;int_name;298;.
And they would use existing translations for railway|abandoned|bridge.

Ideally we'd have separate rendering styles for abandoned and disused bridges which would be similar to abandoned and disused lines respectively. Then we'll need to add translations into `types_strings.txt` also. If you feel its too much to do then I think its fine to combine both of them into a single style, e.g. `railway|abandoned|bridge;[railway=abandoned][bridge?],[railway=disused][bridge?];;name;int_name;298;`. And they would use existing translations for `railway|abandoned|bridge`.

data/styles/outdoors/include/Roads.mapcss

pastk commented

2024-12-06 17:08:32 +00:00

should be visible from z13-

pastk commented

2024-12-06 17:08:58 +00:00

from z16- it becomes thicker

pastk reviewed 2024-12-30 07:50:45 +00:00

data/mapcss-mapping.csv

					
				@ -399,3 +398,3 @@

				railway|abandoned|bridge;[railway=abandoned][bridge?];;name;int_name;298;

				railway|disused|bridge;[railway=disused][bridge?];;name;int_name;298;

				man_made|lighthouse;299;

				deprecated:highway|path|demanding_mountain_hiking:04.2024;[highway=path][sac_scale=demanding_mountain_hiking];x;name;int_name;300;highway|path|difficult

pastk commented

2024-12-30 07:49:45 +00:00

Please change it to railway|disused|bridge;[railway=disused][bridge?],[railway=abandoned][bridge?];;name;int_name;298;

Please change it to `railway|disused|bridge;[railway=disused][bridge?],[railway=abandoned][bridge?];;name;int_name;298;`

data/mapcss-mapping.csv

pastk commented

2024-12-30 07:50:35 +00:00

railway|disused|tunnel;[railway=disused][tunnel?],[railway=abandoned][tunnel?];;name;int_name;400;

```suggestion railway|disused|tunnel;[railway=disused][tunnel?],[railway=abandoned][tunnel?];;name;int_name;400; ```

This repo is archived. You cannot comment on pull requests.

No reviewers

No labels

Android Automotive (AAOS)

API

AppGallery

AppStore

Battery and Performance

External Map Datasets

F-Droid

Fonts

Frequently User Reported

No milestone

No project

No assignees

3 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#9758

Rows
Columns