Add more POI types - create a separate issue for each POI type please #1917

Open
opened 2022-01-20 09:02:31 +00:00 by pastk · 14 comments
Member

Here is a list of POIs good to add:
(below there is a how-to guide)

Not POIs:

Here is a list of POIs good to add: (below there is [a how-to guide](https://git.omaps.dev/organicmaps/organicmaps/issues/1917#issuecomment-1030623850)) - [ ] [`leisure=dance`](https://wiki.openstreetmap.org/wiki/Tag:leisure%3Ddance) (8k objects) Also there was [a request](https://t.me/OrganicMapsRu/13512) to add [`amenity=dancing_school`](https://wiki.openstreetmap.org/wiki/Tag:amenity%3Ddancing_school), however its just 400 objects so maybe its better to merge them. - [ ] `amenity=studio` and maybe its `studio=*` subtypes. - [x] More shops, e.g. `shop=deli/general/grocery/farm/cheese/art/antiques` etc. #2765 - [x] shop=medical_supply - [x] #2017 [`shop=sewing`](https://wiki.openstreetmap.org/wiki/Tag:shop%3Dsewing) merged with [`shop=haberdashery`](https://wiki.openstreetmap.org/wiki/Tag:shop%3Dhaberdashery) - [ ] `amenity=give_box`, `shop=second_hand/charity`, `amenity=social_facility` w/ `social_facility=*` - [ ] `shop=clothes second_hand=only` https://git.omaps.dev/organicmaps/organicmaps/issues/1917#issuecomment-1054133070 - [x] `amenity=parcel_locker` (merge w/ `vending=parcel_pickup`) - [ ] #1660 `tourism=camp_pitch` - [x] #4053 `healthcare=blood_donation/physiotherapist/vaccination_centre/etc.` and #1050 - [ ] #2112 - [ ] https://git.omaps.dev/organicmaps/organicmaps/issues/9416 - [x] #210 - [x] #2181 - [ ] #2183 - [x] `amenity=bicycle_repair_station` - [x] #3139 - [ ] #5521 - [ ] `military=office` (and maybe `office=military`) - [ ] [`leisure=firepit`](https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dfirepit) - [ ] shop=games (2.7k usages, not the same as video_games) Not POIs: - [ ] `landuse=plant_nursery` - [ ] `natural=tree_row` - [ ] #2873 - [ ] #2931 - [ ] #5513
Author
Member

The process to add new POI types is described in the docs

The process to add new POI types is described in [the docs](https://github.com/organicmaps/organicmaps/blob/master/docs/STYLES.md#how-to-add-a-new-map-feature--poi-type)
biodranik commented 2022-02-05 17:52:53 +00:00 (Migrated from github.com)

No relaxing! It should be tested at least locally. Compile generator_tool target, and build some small region map with it to test your new types.

No relaxing! It should be tested at least locally. Compile generator_tool target, and build some small region map with it to test your new types.
Member

The process to add new POI types looks roughly like this:

This is great info, could you add it to the wiki? :)

> The process to add new POI types looks roughly like this: This is great info, could you add it to the wiki? :)
vng commented 2022-02-12 08:45:46 +00:00 (Migrated from github.com)
  1. Add new or fix current classifier tests here ./generator/generator_tests/osm_type_tests.cpp
10. Add new or fix current classifier tests here ./generator/generator_tests/osm_type_tests.cpp
FinixFighter commented 2022-02-28 10:56:39 +00:00 (Migrated from github.com)

When dealing with second hand shops, I think that tag "second_hand=only" should be also considered. For example, there are POI tagged as shop=clothes, plus the tag second_hand=only (here is an example: https://www.openstreetmap.org/node/4191473647). For more examples: use this query
node [second_hand=only] ({{bbox}}); out;
on http://overpass-turbo.eu/

When dealing with second hand shops, I think that tag "second_hand=only" should be also considered. For example, there are POI tagged as shop=clothes, plus the tag second_hand=only (here is an example: https://www.openstreetmap.org/node/4191473647). For more examples: use this query `node [second_hand=only] ({{bbox}}); out;` on http://overpass-turbo.eu/
biodranik commented 2022-02-28 11:40:16 +00:00 (Migrated from github.com)

@FinixFighter what exactly do you propose to do? How to render these tags/shops?

@FinixFighter what exactly do you propose to do? How to render these tags/shops?
FinixFighter commented 2022-02-28 14:08:44 +00:00 (Migrated from github.com)

@FinixFighter what exactly do you propose to do? How to render these tags/shops?

I think they should be shown when the user searches for second hand stores. Easiest way is to render them normally, or they could have the phrase "used only" in the description (written in the same section of restaurant's types of cousine).

> @FinixFighter what exactly do you propose to do? How to render these tags/shops? I think they should be shown when the user searches for second hand stores. Easiest way is to render them normally, or they could have the phrase "used only" in the description (written in the same section of restaurant's types of cousine).
j13m126 commented 2022-06-11 12:39:33 +00:00 (Migrated from github.com)

@pastk #2711 got merged, please update

@pastk #2711 got merged, please update
TheAdventurer64 commented 2022-07-29 10:16:07 +00:00 (Migrated from github.com)

Could amenity=music_school be added?

Could `amenity=music_school` be added?
Member

Added charity shop & second_hand (organicmaps/organicmaps#3132)

Added charity shop & second_hand (https://git.omaps.dev/organicmaps/organicmaps/pulls/3132)
Eleferen commented 2022-08-20 20:54:59 +00:00 (Migrated from github.com)

Please, add Transformer substation
"power=substation" (https://wiki.openstreetmap.org/wiki/Tag:power=substation)

and "power=switch" (https://wiki.openstreetmap.org/wiki/Tag%3Apower%3Dswitch)

Please, add Transformer substation "power=substation" (https://wiki.openstreetmap.org/wiki/Tag:power=substation) and "power=switch" (https://wiki.openstreetmap.org/wiki/Tag%3Apower%3Dswitch)
mpawelski commented 2022-08-21 12:16:48 +00:00 (Migrated from github.com)

When dealing with second hand shops, I think that tag "second_hand=only" should be also considered. For example, there are POI tagged as shop=clothes, plus the tag second_hand=only (here is an example: https://www.openstreetmap.org/node/4191473647). For more examples: use this query node [second_hand=only] ({{bbox}}); out; on http://overpass-turbo.eu/

@FinixFighter what exactly do you propose to do? How to render these tags/shops?

I think they should be shown when the user searches for second hand stores. Easiest way is to render them normally, or they could have the phrase "used only" in the description (written in the same section of restaurant's types of cousine).

Not sure about other combinations of second_hand=only (like with shop=car or shop=books). But for me shop=clothes second_hand=only is quite a distinct type of shop and quite popular (especially in Poland, there is even an article on Polish Wikipedia about it 😅).

I think having "t-shirt" icon like for current shop=clothes but with "recycle arrows" like for shop=second_hand would be nice. We should also label those as "Used clothes shop" or something like that (iD editor name them "Secondhand Clothing Store")

image

> When dealing with second hand shops, I think that tag "second_hand=only" should be also considered. For example, there are POI tagged as shop=clothes, plus the tag second_hand=only (here is an example: https://www.openstreetmap.org/node/4191473647). For more examples: use this query `node [second_hand=only] ({{bbox}}); out;` on http://overpass-turbo.eu/ > > @FinixFighter what exactly do you propose to do? How to render these tags/shops? > > I think they should be shown when the user searches for second hand stores. Easiest way is to render them normally, or they could have the phrase "used only" in the description (written in the same section of restaurant's types of cousine). Not sure about other combinations of `second_hand=only` (like with `shop=car` or `shop=books`). But for me `shop=clothes second_hand=only` is quite a distinct type of shop and [quite popular](https://overpass-turbo.eu/s/1le6) (especially in Poland, there is even an [article](https://pl.wikipedia.org/wiki/Sklep_z_u%C5%BCywan%C4%85_odzie%C5%BC%C4%85) on Polish Wikipedia about it 😅). I think having "t-shirt" icon like for current `shop=clothes` but with "recycle arrows" [like for `shop=second_hand`](https://git.omaps.dev/organicmaps/organicmaps/pulls/3132) would be nice. We should also label those as "Used clothes shop" or something like that (iD editor name them "Secondhand Clothing Store") ![image](https://user-images.githubusercontent.com/2056282/185789810-a46e75c0-b5f2-4a96-8d39-a4aa31697641.png)
PetbkA commented 2022-08-26 06:41:24 +00:00 (Migrated from github.com)

There are many medical supply shops (orthopedic, for instance), but there's no such type in OM. I suggest to add it

There are many [medical supply](https://wiki.openstreetmap.org/wiki/Tag:shop%3Dmedical_supply) shops (orthopedic, for instance), but there's no such type in OM. I suggest to add it
biodranik commented 2022-08-26 07:00:01 +00:00 (Migrated from github.com)

Please, add Transformer substation

@Eleferen why do you need it? Why do you think that users worldwide will need it?

> Please, add Transformer substation @Eleferen why do you need it? Why do you think that users worldwide will need it?
This repo is archived. You cannot comment on issues.
No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
No milestone
No project
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#1917
No description provided.